fix(dashboard-auth): route password-capable providers to /login instead of /auth/login - #60247
Closed
jon9314 wants to merge 1 commit into
Closed
fix(dashboard-auth): route password-capable providers to /login instead of /auth/login#60247jon9314 wants to merge 1 commit into
jon9314 wants to merge 1 commit into
Conversation
…ad of /auth/login BasicAuthProvider and other password-capable providers do not implement the OAuth redirect flow in start_login(). The auto-sso middleware was sending them to /auth/login, where start_login() raises NotImplementedError and the request returns HTTP 500. Restrict the OAuth auto-redirect to providers that actually need it. When a provider exposes password login, redirect to the unified login form instead. Fixes auth redirection bug for dashboard instances using basic auth.
Collaborator
Duplicate of #54887 (earliest-open canonical fix for the dashboard password-only auth 500). Both patch |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduces and fixes the tracked BasicAuthProvider 500 on current main.
Fixes #58166