fix(mcp): move t.cancel() inside try block to prevent RuntimeError on /exit - #60287
Closed
AIalliAI wants to merge 1 commit into
Closed
fix(mcp): move t.cancel() inside try block to prevent RuntimeError on /exit#60287AIalliAI wants to merge 1 commit into
AIalliAI wants to merge 1 commit into
Conversation
… /exit
During shutdown, the event loop is closed before MCP tasks finish, so
t.cancel() → call_soon() raises RuntimeError('Event loop is closed').
Moved t.cancel() inside the try block at both locations (keepalive
loop and _wait_for_reconnect_or_shutdown).
Closes NousResearch#60197
(cherry picked from commit 8c7afb4)
Co-authored-by: AIalliAI <285906080+AIalliAI@users.noreply.github.com>
alt-glitch
added
type/bug
Collaborator
Duplicate of #60032 — this is a cherry-pick of #60213, and all three (#60032, #60213, this) move |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #60213 by webtecnica.
During shutdown, the event loop is closed before MCP tasks finish, so t.cancel() raises RuntimeError("Event loop is closed"). Moved t.cancel() inside the try block at both locations in tools/mcp_tool.py.
(cherry picked from commit 8c7afb4)
Co-authored-by: webtecnica 75556242+webtecnica@users.noreply.github.com
Closes #60197