fix(mcp): move t.cancel() inside try block to prevent RuntimeError on exit (#60197) - #60213
Closed
webtecnica wants to merge 1 commit into
Closed
fix(mcp): move t.cancel() inside try block to prevent RuntimeError on exit (#60197)#60213webtecnica wants to merge 1 commit into
webtecnica wants to merge 1 commit into
Conversation
… /exit
During shutdown, the event loop is closed before MCP tasks finish, so
t.cancel() → call_soon() raises RuntimeError('Event loop is closed').
Moved t.cancel() inside the try block at both locations (keepalive
loop and _wait_for_reconnect_or_shutdown).
Closes NousResearch#60197
Contributor
Author
alt-glitch
added
type/bug
Collaborator
|
14 tasks
This was referenced Jul 7, 2026
Contributor
Author
|
Closing as duplicate — the sweeper identified this as already covered by another PR. Thanks for the contribution! |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RuntimeError when /exit is called with MCP tasks running. Moved t.cancel() inside try block at both cleanup locations. Closes #60197