fix(tools): recognize WhatsApp LID format in send_message target parsing - #59199
Closed
wesleysimplicio wants to merge 1 commit into
Closed
fix(tools): recognize WhatsApp LID format in send_message target parsing#59199wesleysimplicio wants to merge 1 commit into
wesleysimplicio wants to merge 1 commit into
Conversation
WhatsApp Web.js uses LID format (digits@lid) for certain contact IDs, but _parse_target_ref() only recognizes E.164 phone number format. Add a regex and branch for WhatsApp LID IDs so send_message works without requiring a home_channel. Closes NousResearch#59136
alt-glitch
added
type/bug
Collaborator
Duplicate of #59166 — both fix #59136 with the same WhatsApp LID ( |
Contributor
Author
|
Fechando como duplicada de #59166, conforme triagem. Vou concentrar o acompanhamento na PR canônica. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59136
WhatsApp Web.js uses LID format (digits@lid) for certain contact IDs,
but _parse_target_ref() only recognizes E.164 phone number format.
Adds a regex and branch for WhatsApp LID IDs so send_message works
without requiring a home_channel.
Change: tools/send_message_tool.py:_parse_target_ref()