Skip to content

fix(send_message): accept WhatsApp LID targets - #59166

Closed
doncazper wants to merge 1 commit into
NousResearch:mainfrom
doncazper:codex/whatsapp-lid-send-message
Closed

fix(send_message): accept WhatsApp LID targets#59166
doncazper wants to merge 1 commit into
NousResearch:mainfrom
doncazper:codex/whatsapp-lid-send-message

Conversation

@doncazper

Copy link
Copy Markdown
Contributor

Summary

  • recognize WhatsApp digits@lid targets as explicit direct targets via a WhatsApp-only parser branch
  • keep LID handling from broadening Signal/SMS/Photon target parsing
  • add parser and send_message_tool regression coverage for whatsapp:37576702443707@lid without home-channel fallback

Fixes #59136

Tests

  • python -m py_compile tools/send_message_tool.py tests/tools/test_send_message_tool.py
  • uv run --extra dev --extra messaging python -m pytest tests/tools/test_send_message_tool.py -q (152 passed, 1 warning: discord.py audioop deprecation)
  • uv run --extra dev ruff check tools/send_message_tool.py tests/tools/test_send_message_tool.py
  • uv run --extra dev --extra messaging python -m py_compile tools/send_message_tool.py tests/tools/test_send_message_tool.py

@alt-glitch alt-glitch added type/bug Something isn't working comp/tools Tool registry, model_tools, toolsets platform/whatsapp WhatsApp Business adapter sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages P2 Medium — degraded but workaround exists labels Jul 5, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused regression coverage. This is already resolved on current main (automated hermes-sweeper review).

  • ea49a79633d93202d8e495648b2586ee5a1fbecc added native WhatsApp JID parsing, including @lid.
  • tools/send_message_tool.py:4749 includes lid in _WHATSAPP_JID_RE, and tools/send_message_tool.py:590595 returns matching WhatsApp JIDs as explicit targets.
  • tools/send_message_tool.py:367378 only resolves the channel directory for non-explicit targets, so an @lid target does not fall back to the home channel.
  • tests/tools/test_send_message_tool.py:15941614 already covers the LID behavior and confirms it remains WhatsApp-only.
  • The existing fix shipped in v2026.6.19.

This also confirms the prior resolution noted on #59136.

@teknium1 teknium1 closed this Jul 15, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists platform/whatsapp WhatsApp Business adapter sweeper:implemented-on-main Sweeper: behavior already present on current main sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WhatsApp LID format not recognized in send_message tool

3 participants