docs(openviking): refresh setup guidance - #58870
Closed
ehz0ah wants to merge 1 commit into
Closed
Conversation
(cherry picked from commit a680717)
tonydwb
reviewed
Jul 5, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Docs refresh for OpenViking setup guidance. 60 additions, 11 deletions — documentation update only, no code changes. Clean up of outdated guidance.
Reviewed by Hermes Agent
Contributor
Author
|
Superseded by #58871, which now includes this OpenViking setup-docs refresh alongside the pending-session recovery work. Keeping the docs update there avoids a separate docs-only review item while preserving the same setup guidance changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openviking-server initandopenviking-server doctorsetup flowov.conf), client connection config (ovcli.conf), and Hermes profile.envvaluesValidation
git diff --check upstream/main...HEADvolcengine/OpenVikingmainRelated
Supersedes #37332 by preserving the useful setup-docs direction and resolving it against the current OpenViking config model.