docs: clarify OpenViking local setup - #37332
Conversation
|
Thanks for the detailed local-setup documentation. The profile-local and tenant-configuration direction is useful, but this patch needs alignment with the current provider behavior and the related successor work. Problems
Suggested changes
Automated hermes-sweeper review. |
GottZ
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Summary
Two PRs address the OpenViking documentation gap, but neither has a recorded Verify verdict. #37332 adds profile-local configuration, Ollama embedding, and validation guidance, while #58870 updates the same setup surface to the current openviking-server init/doctor flow and separates ov.conf, ovcli.conf, and Hermes profile configuration.
Related pull requests
- #37332
related— (+129/-8) — keep open with a salvage path: the diff contains useful Ollamanomic-embed-text, embedding-only behavior, profile isolation, and validation guidance, but its all-.envframing and API-key tenant claims conflict with the provider behavior cited atplugins/memory/openviking/__init__.py:878-897andplugins/memory/openviking/__init__.py:234-259. This follows the maintainer-bot keep_open review: salvage those additions while documenting both connection paths and the actual trusted/API-key header semantics using #58871's current setup boundary. - #58870 [closed]
duplicate— (+60/-11) — superseded reference implementation: its diff directly corrects the outdated setup model withopenviking-server init/doctorand explicitov.conf/ovcli.conf/profile-.envboundaries. Although closed, it remains relevant because contributor review records that #58871 incorporates this documentation refresh, avoiding a separate docs-only change.
Duplicates
#37332 and #58870 partially duplicate the profile-local OpenViking setup documentation; #58870's current configuration model was subsequently folded into #58871, while #37332 retains distinct Ollama and embedding-only guidance.
Suggested consolidation
Keep #37332 open with a salvage path, consistent with the maintainer-bot verdict: retain its Ollama embedding example, embedding-only storage/extraction caveat, profile-isolation example, and validation commands, but rework them onto #58871's openviking-server init/doctor and ov.conf/ovcli.conf boundaries and correct the tenant-header semantics. #58870 is already closed and superseded by #58871; treat its overlapping setup changes as the reference for consolidating that portion rather than reopening it.
Complex graph
flowchart LR
classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
classDef best stroke-width:3px,stroke:#b45309
classDef target stroke-width:3px,stroke:#4338ca
subgraph Dup37332 ["PRs duplicating each other"]
P37332["PR #37332 (open)"]
P58870["PR #58870 (closed)"]
end
class P37332 open
class P58870 closed
class P37332 target
click P37332 "https://github.com/NousResearch/hermes-agent/pull/37332"
click P58870 "https://github.com/NousResearch/hermes-agent/pull/58870"
Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).
Cross-PR triage: Reviewed 2 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 11 kB of PR diffs, 2 kB of issue/PR text, <1 kB of discussion (2 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.
|
Thanks for the contribution. This PR should close because current main already documents profile-specific setup and the correct separation between Hermes settings, ovcli.conf, and ov.conf. OpenViking now owns local model setup through openviking-server init and doctor. Any detailed Ollama guide should be maintained in OpenViking to prevent the Hermes documentation from becoming outdated. |
Summary
.envconfigurationOPENVIKING_ACCOUNT,OPENVIKING_USER, andOPENVIKING_AGENTnomic-embed-textembedding setup guidance and validation commandsValidation
PYTHONPATH=. /home/npfernando/.hermes/hermes-agent/venv/bin/python -m pytest tests/plugins/memory/test_openviking_provider.py tests/openviking_plugin/test_openviking.py -q -o 'addopts='→ 30 passednpx docusaurus build --locale en→ passedNotes
npm run typecheckcurrently fails on an unrelated existing issue insrc/components/UserStoriesCollage/index.tsx(Cannot find namespace 'JSX')./docs/user-guide/features/web-dashboardto/docs/integrations/mcp.