Skip to content

fix(gateway): cap proxy SSE buffer to prevent unbounded memory growth #58622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexFucuson9 wants to merge 1 commit into from
Closed

fix(gateway): cap proxy SSE buffer to prevent unbounded memory growth #58622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions gateway/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16177,6 +16177,7 @@ def _pause_typing_before_finalize(
}

# Parse SSE stream
_SSE_BUFFER_CAP = 1 << 20 # 1 MiB — reject boundary-less lines
buffer = ""
async for chunk in resp.content.iter_any():
if not _run_still_current():
Expand All @@ -16197,6 +16198,12 @@ def _pause_typing_before_finalize(
text = chunk.decode("utf-8", errors="replace")
buffer += text

if len(buffer) > _SSE_BUFFER_CAP:
raise RuntimeError(
f"Proxy SSE buffer exceeded {_SSE_BUFFER_CAP} bytes "
"without a line boundary — aborting"
)

# Process complete SSE lines
while "\n" in buffer:
line, buffer = buffer.split("\n", 1)
Expand Down