fix(gateway): cap proxy SSE buffer to prevent unbounded memory growth - #58622
Closed
AlexFucuson9 wants to merge 1 commit into
Closed
AlexFucuson9 wants to merge 1 commit into
AlexFucuson9 wants to merge 1 commit into
Conversation
Gateway proxy mode parses SSE streams by appending chunks to a buffer and splitting on newlines. A malformed or boundary-less upstream can grow the buffer without limit, eventually OOMing the process. Add a 1 MiB cap on the residual buffer. If the buffer exceeds this without seeing a line boundary, raise RuntimeError to abort the proxy connection instead of continuing to accumulate. Fixes NousResearch#58471
|
Collaborator
|
Thanks for identifying the unbounded residual-SSE-buffer failure mode. Automated hermes-sweeper review found that current
Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gateway proxy mode parses SSE streams by appending chunks to a buffer and splitting on newlines. A malformed or boundary-less upstream can grow the buffer without limit, eventually OOMing the process.
Root Cause
In
gateway/run.py::_run_agent_via_proxy, the successful SSE path:If the remote proxy sends a long malformed SSE line without a newline boundary, the residual
bufferhas no cap.Fix
Add a 1 MiB cap on the residual buffer. If the buffer exceeds this without seeing a line boundary, raise
RuntimeErrorto abort the proxy connection instead of continuing to accumulate.Fixes #58471