fix(website-policy): key blocklist cache on real default config path (salvage #3923) - #58526
Merged
Merged
Conversation
The cache used a '__default__' sentinel as its path key, so switching HERMES_HOME (profiles, tests) within one process kept serving the stale policy loaded from the previous home. Key the cache on the actual resolved default config path instead, so a home/config-path change naturally misses the cache. Trimmed from bundled PR #3923 (the other sub-fixes are superseded on main); authored by @aydnOktay.
alt-glitch
added
type/bug
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…website-policy-cache-key fix(website-policy): key blocklist cache on real default config path (salvage NousResearch#3923)
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…website-policy-cache-key fix(website-policy): key blocklist cache on real default config path (salvage NousResearch#3923)
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…website-policy-cache-key fix(website-policy): key blocklist cache on real default config path (salvage NousResearch#3923)
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…website-policy-cache-key fix(website-policy): key blocklist cache on real default config path (salvage NousResearch#3923)
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…website-policy-cache-key fix(website-policy): key blocklist cache on real default config path (salvage NousResearch#3923)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The website blocklist cache no longer serves a stale policy after
HERMES_HOME/ default-config-path changes within one process (profile switches, tests): the cache is now keyed on the real resolved default config path instead of a"__default__"sentinel.Trimmed salvage of bundled PR #3923 by @aydnOktay — this was the one sub-fix still valid; commit carries the contributor's authorship.
Changes
tools/website_policy.pyload_website_blocklist(): cache key =str(_get_default_config_path()); a home/config-path change now naturally misses the cache (+3/−2).Validation
tests/tools/test_website_policy.pyNot salvaged from #3923 (superseded/wrong direction)
auth_testsync/coroutine shim → written to appease test mocks; Fix Slack multi-workspace token and routing regressions #3928 covers the real connect() issues_preflight_codex_api_kwargsgh pr comment || true→ main already uses|| echo ::warningInfographic