Fix Slack multi-workspace token and routing regressions - #3928
Closed
kshitijk4poor wants to merge 1 commit into
Closed
kshitijk4poor wants to merge 1 commit into
kshitijk4poor wants to merge 1 commit into
Conversation
kshitijk4poor
marked this pull request as ready for review
March 30, 2026 09:28
11 tasks
Collaborator
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
channel_id -> team_idrouting toslack_channel_teams.jsonso outbound sends after restart reach the correct workspaceteam_idmetadata when availableWhy
The upstream multi-workspace Slack change introduced two regressions:
slack_tokens.jsoncould abortconnect()and keep Slack fully offlinechannel_not_foundThis PR makes token validation per-workspace and persists learned channel routing so workspace selection survives process restarts.
Validation
source .venv/bin/activate && python -m pytest tests/gateway/test_slack.py -qsource .venv/bin/activate && python -m py_compile gateway/platforms/slack.py tests/gateway/test_slack.py