fix(cli): preserve static custom provider models + prune stale custom credentials (2-PR salvage) - #58505
Merged
Conversation
teknium1
force-pushed
the
salvage/config-auth-cron
branch
from
July 5, 2026 07:39
2ffb1a4 to
e581c58
Compare
teknium1
enabled auto-merge (rebase)
July 5, 2026 07:40
teknium1
force-pushed
the
salvage/config-auth-cron
branch
from
July 5, 2026 07:51
e581c58 to
266ab8e
Compare
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two config/auth fixes: custom providers declaring
models:as dict rows ([{id: ...}]) no longer show zero models in the picker, and stalemodel_configcredential mirrors are pruned when the user switches custom endpoints (stops requests going to the old endpoint).Salvages #58453 (@lord-dubious) and #58409 (@msh01) onto current main, authorship preserved. The cron per-job max_tokens PR (#58440) originally clustered here was dropped by maintainer decision — per-job token caps are not a user-facing knob we want.
Changes
hermes_cli/model_switch.py+hermes_cli/config.py: new_declared_model_ids()helper accepting string and dict (id/name) rows, replacing 4 divergent ad-hoc parsers (refs Desktop model picker cannot reliably show or select configured custom OpenAI-compatible providers #58393)hermes_cli/model_setup_flows.py: after an explicit custom-endpoint save, prunesource=="model_config"entries from inactivecustom:*pools;manualentries retained (refs [Bug]: auth.json caches credentials, causing double requests, old and new endpoints #57569)Validation
Targeted suites: inventory, model_switch custom providers, model_setup_flows — all pass.
Closes #58453. Closes #58409.
Infographic