Skip to content

fix(cli): preserve static custom provider models + prune stale custom credentials (2-PR salvage) - #58505

Merged
teknium1 merged 3 commits into
mainfrom
salvage/config-auth-cron
Jul 5, 2026
Merged

fix(cli): preserve static custom provider models + prune stale custom credentials (2-PR salvage)#58505
teknium1 merged 3 commits into
mainfrom
salvage/config-auth-cron

Conversation

@teknium1

@teknium1 teknium1 commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Two config/auth fixes: custom providers declaring models: as dict rows ([{id: ...}]) no longer show zero models in the picker, and stale model_config credential mirrors are pruned when the user switches custom endpoints (stops requests going to the old endpoint).

Salvages #58453 (@lord-dubious) and #58409 (@msh01) onto current main, authorship preserved. The cron per-job max_tokens PR (#58440) originally clustered here was dropped by maintainer decision — per-job token caps are not a user-facing knob we want.

Changes

Validation

Before After
custom provider with dict-row models picker shows (0) models models listed
switch custom endpoint old-endpoint cred can still be selected stale mirror pruned

Targeted suites: inventory, model_switch custom providers, model_setup_flows — all pass.

Closes #58453. Closes #58409.

Infographic

config-auth-cron

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management area/auth Authentication, OAuth, credential pools sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data P2 Medium — degraded but workaround exists labels Jul 4, 2026
@teknium1
teknium1 force-pushed the salvage/config-auth-cron branch from 2ffb1a4 to e581c58 Compare July 5, 2026 07:39
@teknium1 teknium1 changed the title fix(cli,cron): static custom provider models, stale custom cred pruning, per-job max_tokens (3-PR salvage) fix(cli): preserve static custom provider models + prune stale custom credentials (2-PR salvage) Jul 5, 2026
@teknium1
teknium1 enabled auto-merge (rebase) July 5, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management P2 Medium — degraded but workaround exists sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants