Skip to content

fix(auth): prune stale custom model credentials - #58409

Closed
tianma-if wants to merge 1 commit into
NousResearch:mainfrom
tianma-if:codex/custom-provider-stale-credentials
Closed

fix(auth): prune stale custom model credentials#58409
tianma-if wants to merge 1 commit into
NousResearch:mainfrom
tianma-if:codex/custom-provider-stale-credentials

Conversation

@tianma-if

Copy link
Copy Markdown
Contributor

Summary

  • prune stale custom endpoint credential-pool entries sourced from the previous model_config when a new custom endpoint is explicitly saved
  • keep manual credentials for other custom providers intact
  • add a regression test that drives the real custom model setup flow and verifies the old pool no longer keeps the replaced model_config credential

Fixes #57569.

Tests

  • .venv/bin/python -m pytest tests/hermes_cli/test_custom_provider_model_switch.py -q
  • .venv/bin/python -m ruff check hermes_cli/model_setup_flows.py tests/hermes_cli/test_custom_provider_model_switch.py
  • git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard area/auth Authentication, OAuth, credential pools P2 Medium — degraded but workaround exists sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data labels Jul 4, 2026
@teknium1

teknium1 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Merged via PR #58505 (#58505). Your commit was cherry-picked onto current main with your authorship preserved in git log (7915837). Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: auth.json caches credentials, causing double requests, old and new endpoints

3 participants