Skip to content

fix(model-switch): skip providers not in PROVIDER_REGISTRY from /model picker #57711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexFucuson9 wants to merge 1 commit into from
Closed

fix(model-switch): skip providers not in PROVIDER_REGISTRY from /model picker #57711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions hermes_cli/model_switch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1628,11 +1628,18 @@ def _has_aws_sdk_creds_for_listing(slug: str) -> bool:
# source of truth. models.dev can have wrong mappings (e.g.
# minimax-cn → MINIMAX_API_KEY instead of MINIMAX_CN_API_KEY).
pconfig = PROVIDER_REGISTRY.get(hermes_id)
# Providers not in PROVIDER_REGISTRY cannot be resolved by
# resolve_provider_full() — they appear in the picker via
# models.dev but selecting them fails with "Unknown provider".
# Skip them; the user's custom_providers entry (if any) covers
# the same vendor under a routable slug. See #57503.
if pconfig is None:
continue
# Skip non-API-key auth providers here — they are handled in
# section 2 (HERMES_OVERLAYS) with proper auth store checking.
if pconfig and pconfig.auth_type != "api_key":
if pconfig.auth_type != "api_key":
continue
if pconfig and pconfig.api_key_env_vars:
if pconfig.api_key_env_vars:
env_vars = list(pconfig.api_key_env_vars)
else:
env_vars = pdata.get("env", [])
Expand Down