fix(model-switch): skip providers not in PROVIDER_REGISTRY from /model picker - #57711
Closed
AlexFucuson9 wants to merge 1 commit into
Closed
fix(model-switch): skip providers not in PROVIDER_REGISTRY from /model picker#57711AlexFucuson9 wants to merge 1 commit into
AlexFucuson9 wants to merge 1 commit into
Conversation
…l picker Providers that appear in PROVIDER_TO_MODELS_DEV (models.dev) but have no entry in PROVIDER_REGISTRY (auth.py) cannot be resolved by resolve_provider_full(). Selecting them in the /model picker fails with "Unknown provider '<name>'". This affected mistral (72 models from models.dev, 0 routable). When a user also had a custom_providers entry for Mistral, two entries appeared — one broken (built-in) and one working (custom). Fix: skip any PROVIDER_TO_MODELS_DEV entry whose hermes_id is not in PROVIDER_REGISTRY. The user's custom_providers entry (if any) covers the same vendor under a routable slug. Fixes NousResearch#57503
alt-glitch
added
type/bug
Collaborator
Duplicate of #57568 — that earlier open PR (created ~5.5h before this one) adds the identical |
8 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57503
Providers in
PROVIDER_TO_MODELS_DEV(models.dev) that have no entry inPROVIDER_REGISTRY(auth.py) cannot be resolved byresolve_provider_full(). Selecting them in the/modelpicker fails withUnknown provider '<name>'.This affected
mistral(72 models from models.dev, 0 routable). When a user also had acustom_providersentry for Mistral, two entries appeared — one broken (built-in) and one working (custom).Fix
Skip any
PROVIDER_TO_MODELS_DEVentry whosehermes_idis not inPROVIDER_REGISTRY. The user'scustom_providersentry (if any) covers the same vendor under a routable slug.Files Changed
hermes_cli/model_switch.py— addedPROVIDER_REGISTRYpresence check before listing provider in picker