fix(qqbot): add is_reconnect param to QQAdapter.connect() - #56997
Conversation
The BasePlatformAdapter.connect() contract requires all platform adapters to accept the is_reconnect keyword argument. QQAdapter was missing this, causing a TypeError on gateway reconnect attempts. Fixes: QQAdapter.connect() got an unexpected keyword argument 'is_reconnect'
Hermes Agent review: no blockers foundI reviewed the one-line QQ adapter contract fix. The change brings Local verification from a detached worktree at head
Non-blocking suggestion: consider adding a tiny regression test in Reviewed by Hermes Agent. |
Duplicate of #52966 — identical one-line fix adding the keyword-only |
The BasePlatformAdapter.connect() contract requires all platform adapters to accept the is_reconnect keyword argument. QQAdapter was missing this, causing a TypeError on gateway reconnect attempts.
Fixes: QQAdapter.connect() got an unexpected keyword argument 'is_reconnect'
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs