fix(desktop): restore styled tooltips on right sidebar file tree buttons and rows - #56520
Open
wnuuee1 wants to merge 2 commits into
Open
fix(desktop): restore styled tooltips on right sidebar file tree buttons and rows#56520wnuuee1 wants to merge 2 commits into
wnuuee1 wants to merge 2 commits into
Conversation
19 tasks
19 tasks
19 tasks
Contributor
|
Thanks for identifying the regression. Current main still uses native Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Refresh and Collapse All buttons in the right sidebar's file tree header, and each file/folder row in the file tree itself, showing plain browser-native tooltips instead of the app's styled dark tooltip.
This restores work from #51315 ("replace native title tooltips with styled Tip component"), which wrapped these buttons in
<Tip>. #49037 rewroteFilesystemTabas part of the Projects feature, and its merge reintroduced the nativetitle=attributes, reverting the tooltip fix from #51315. #49037 also removed the Open Folder button from that same file — its PR description states the freeform folder picker was retired in favor of project/worktree-based workspace switching, so that change is intentional and out of scope here. Only the two remaining buttons need the tooltip restored.Additionally,
ProjectTree(./files/tree.tsx) rendered each file/folder row with a nativetitle={node.data.id}showing the full path, which had the same plain-tooltip regression. This wasn't touched by #51315 originally, so it's addressed here with the same fix.Related Issue
Fixes #
Type of Change
Changes Made
apps/desktop/src/app/right-sidebar/index.tsx— replaced nativetitle=with<Tip label={...} side="left">on the Refresh and Collapse All buttons inFilesystemTab(regressed by feat(desktop): first-class projects — sidebar, coding rail, review pane, and agent project tools #49037; Open Folder was intentionally removed by that PR and is not restored here)apps/desktop/src/app/right-sidebar/files/tree.tsx— replaced nativetitle={node.data.id}with<Tip label={node.data.id} side="left">on each file tree row inProjectTreeRowHow to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A
Screenshots / Logs