fix(desktop): replace native title tooltips with styled Tip component - #51315
Merged
teknium1 merged 1 commit intoJun 23, 2026
Merged
Conversation
tonydwb
approved these changes
Jun 23, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Replaces native title attributes with styled Tip component across desktop UI elements (context menu, model pill, right sidebar, titlebar controls). Provides consistent tooltip styling instead of browser-native tooltips. Clean UI change.
Reviewed by Hermes Agent
OutThisLife
self-requested a review
June 23, 2026 16:36
OutThisLife
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Several icon buttons across the desktop UI showed plain white browser-native tooltips
on hover instead of the app's styled dark tooltips. The
<Tip>component is alreadyused elsewhere in the app (e.g. the Default workspace button in the statusbar) and
produces the correct dark-themed tooltip style. Replaced all
title=attributeswith this existing
<Tip>component to make tooltips consistent throughout the app.Related Issue
Fixes #
Type of Change
Changes Made
apps/desktop/src/app/shell/titlebar-controls.tsx— replacedtitle=with<Tip>on all titlebar icon buttons (sidebar toggle, swap panes, haptics, keybinds, settings, right sidebar toggle)apps/desktop/src/app/right-sidebar/index.tsx— replacedtitle=with<Tip side="left">on Refresh, Open Folder, and Collapse All buttons inFilesystemTabapps/desktop/src/app/chat/composer/context-menu.tsx— replacedtitle=with<Tip side="top">on the Add Context (+) buttonapps/desktop/src/app/chat/composer/model-pill.tsx— replacedtitle=with<Tip side="top">on both model selector button variantsHow to Test
+(Add context) button in the composer — dark styled tooltipNotes
Right sidebar tooltips use
side="left"because the sidebar is flush againstthe right edge of the window — default positioning caused Radix to place the
tooltip outside the viewport.
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A
Screenshots / Logs
2026-06-23-13-15-25_JuicMKJq.mp4
Infographic