Skip to content

fix(desktop): replace native title tooltips with styled Tip component - #51315

Merged
teknium1 merged 1 commit into
NousResearch:mainfrom
wnuuee1:fix/tooltip-style-consistency
Jun 23, 2026
Merged

fix(desktop): replace native title tooltips with styled Tip component#51315
teknium1 merged 1 commit into
NousResearch:mainfrom
wnuuee1:fix/tooltip-style-consistency

Conversation

@wnuuee1

@wnuuee1 wnuuee1 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Several icon buttons across the desktop UI showed plain white browser-native tooltips
on hover instead of the app's styled dark tooltips. The <Tip> component is already
used elsewhere in the app (e.g. the Default workspace button in the statusbar) and
produces the correct dark-themed tooltip style. Replaced all title= attributes
with this existing <Tip> component to make tooltips consistent throughout the app.

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • apps/desktop/src/app/shell/titlebar-controls.tsx — replaced title= with <Tip> on all titlebar icon buttons (sidebar toggle, swap panes, haptics, keybinds, settings, right sidebar toggle)
  • apps/desktop/src/app/right-sidebar/index.tsx — replaced title= with <Tip side="left"> on Refresh, Open Folder, and Collapse All buttons in FilesystemTab
  • apps/desktop/src/app/chat/composer/context-menu.tsx — replaced title= with <Tip side="top"> on the Add Context (+) button
  • apps/desktop/src/app/chat/composer/model-pill.tsx — replaced title= with <Tip side="top"> on both model selector button variants

How to Test

  1. Hover over any button in the titlebar (top left and top right) — dark styled tooltips
  2. Open the right sidebar, hover over Refresh / Open Folder / Collapse All — dark styled tooltips
  3. Hover over the + (Add context) button in the composer — dark styled tooltip
  4. Hover over the model pill (e.g. "Step 3.7 Flash") — dark styled tooltip

Notes

Right sidebar tooltips use side="left" because the sidebar is flush against
the right edge of the window — default positioning caused Radix to place the
tooltip outside the viewport.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: Windows 11

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

N/A

Screenshots / Logs

2026-06-23-13-15-25_JuicMKJq.mp4

Infographic

styled-tooltips-desktop

@alt-glitch alt-glitch added type/bug Something isn't working comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Jun 23, 2026

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approved

Replaces native title attributes with styled Tip component across desktop UI elements (context menu, model pill, right sidebar, titlebar controls). Provides consistent tooltip styling instead of browser-native tooltips. Clean UI change.


Reviewed by Hermes Agent

@OutThisLife
OutThisLife self-requested a review June 23, 2026 16:36
@OutThisLife
OutThisLife enabled auto-merge (squash) June 23, 2026 16:40
@teknium1
teknium1 merged commit 9fd2b2c into NousResearch:main Jun 23, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants