fix(title): honor configured auxiliary.title_generation.timeout (salvage #41844, #32729)

[kshitijk4poor]

Summary

Salvage of #41844 by @shandian64 (cherry-picked onto current main, authorship preserved). The minimal fix for #32729: auxiliary.title_generation.timeout was silently ignored.

The bug

agent/title_generator.py::generate_title hardcoded timeout: float = 30.0 in its signature. Its caller auto_title_session never passes an explicit timeout, so the hardcoded 30.0 always reached call_llm — and call_llm only resolves auxiliary.title_generation.timeout from config when it's called with timeout=None (auxiliary_client.py:5842: effective_timeout = timeout if timeout is not None else _get_task_timeout(task)). So a user who set a high title-generation timeout for a slow local LLM still saw Request timed out. at 30s every session. Confirmed on main (title_generator.py:54).

The fix (one line)

-    timeout: float = 30.0,
+    timeout: Optional[float] = None,

Optional is already imported; the None default now flows to call_llm, which resolves auxiliary.title_generation.timeout (default 30) from config. An explicit timeout= still overrides. Plus two regression tests: default delegates to config (task=="title_generation", timeout is None) and explicit timeout still forwards.

Chosen over competing PRs (issue #32729)

This was a 4-way OPEN cluster. #41844 is the cleanest: the exact one-line default fix with focused, non-tautological tests and no scope creep. Superseded:

• fix(agent): honor configured auxiliary.title_generation.timeout (#32729) #56285 (Tranquil-Flow) — same core fix + a (harmless but unnecessary) type-annotation tidy on call_llm; thorough tests, but more surface than needed.
• fix(title_gen): honor auxiliary.title_generation.timeout config setting (#41812) #41841 — re-implements the timeout resolution at the gateway/run.py call site that call_llm already does internally — redundant plumbing.
• fix(config): honor configured timeout for auxiliary title generation (#32729) #39035 — contains the correct one-liner but bundles an unrelated arm64 Docker CI rewrite (.github/workflows/docker.yml), which disqualifies it as-is.

Rebase note

The one-liner applied clean; only the test file conflicted (main added language tests in the same region). Resolved by keeping BOTH main's language tests and #41844's timeout tests.

Review

Ran hermes-agent-dev + hermes-pr-review Phase 2c — 0 Critical / 0 Warnings. Confirmed the fix chain end-to-end, config key exists on main, no behavior change for explicit-timeout callers, tests non-tautological. Locally: 25 passed.

Tests

pytest tests/agent/test_title_generator.py -q   # 25 passed (CI runs the full suite)

Supersedes #41844 (and #56285 / #41841 / #39035). Full credit to @shandian64.