Skip to content

fix(title): honor configured auxiliary timeout - #41844

Closed
shandian64 wants to merge 1 commit into
NousResearch:mainfrom
shandian64:codex/title-timeout-config
Closed

fix(title): honor configured auxiliary timeout#41844
shandian64 wants to merge 1 commit into
NousResearch:mainfrom
shandian64:codex/title-timeout-config

Conversation

@shandian64

Copy link
Copy Markdown
Contributor

Summary

  • stop forcing title generation to pass the 30s default timeout into call_llm
  • let call_llm(task="title_generation") resolve auxiliary.title_generation.timeout from config when no explicit timeout is provided
  • add coverage for default-config timeout delegation and explicit timeout overrides

Fixes #41812.

Tests

  • python -m pytest -o addopts= -p no:timeout tests/agent/test_title_generator.py tests/hermes_cli/test_aux_config.py::test_title_generation_present_in_default_config
  • python -m py_compile agent/title_generator.py

@kshitijk4poor

Copy link
Copy Markdown
Collaborator

Superseded by #56322, which carries your commit verbatim (authorship preserved) rebased onto current main (kept both your timeout tests and main's newer language tests). Your one-line fix (generate_title timeout default 30.0 -> Optional[None] so call_llm resolves auxiliary.title_generation.timeout) was the cleanest, creep-free fix in a 4-PR cluster for #32729. Phase 2c: 0 Critical, 25 tests pass. Full credit to you. Closing in favor of #56322.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Regression, auxillary title generation timeout ignores config.yaml settings

3 participants