fix(models): preserve Ollama model:tag colons in parse_model_input

[starm2010]

Problem

When ACP clients (like AionUI) send custom:glm-5.2:cloud to set_session_model, parse_model_input splits at the second colon, treating the middle part (glm-5.2) as a named custom provider name. For Ollama models that use colons in their tags (e.g. glm-5.2:cloud, nomic-embed-text:latest, kimi-k2:1t-cloud), this truncates the model id to just the tag suffix (cloud instead of glm-5.2:cloud), causing HTTP 404 errors from the inference endpoint.

The existing triple-syntax guard (custom:name:model → ("custom:name", "model")) had no way to distinguish between:

• custom:ollama:qwen3 — provider custom:ollama, model qwen3 (intended triple syntax)
• custom:glm-5.2:cloud — provider custom, model glm-5.2:cloud (Ollama tag, NOT triple syntax)

Solution

Add _is_registered_custom_provider() that checks whether the middle part matches a configured custom provider in config.yaml (via get_compatible_custom_providers()). The triple split only happens when the middle part is a registered custom provider name. Otherwise, the full string after custom: is treated as the model id.

# Before (truncates Ollama tags):
if custom_name and actual_model:
    return (f"custom:{custom_name}", actual_model)

# After (only splits for registered custom providers):
if custom_name and actual_model and _is_registered_custom_provider(custom_name):
    return (f"custom:{custom_name}", actual_model)

Testing

• Updated test_custom_triple_syntax and test_custom_triple_spaces to mock _is_registered_custom_provider (since local-server/my-server are not registered providers in the test env)
• Added test_custom_triple_unregistered_falls_back — verifies custom:glm-5.2:cloud with a mocked False returns the full model id
• Added test_custom_ollama_tag_not_truncated — regression test without mocks, verifies real-world Ollama model names pass through intact

Verified manually:

parse_model_input("custom:glm-5.2:cloud", "custom")    → ("custom", "glm-5.2:cloud") ✅
parse_model_input("custom:ollama:qwen3", "custom")      → ("custom:ollama", "qwen3")  ✅
parse_model_input("custom:nomic-embed-text:latest", ..) → ("custom", "nomic-embed-text:latest") ✅
parse_model_input("custom:gpt-4o", "custom")            → ("custom", "gpt-4o")         ✅

Scope

• Only affects the triple-syntax path (custom:name:model). Single-colon path (custom:model) is unchanged.
• No new dependencies. _is_registered_custom_provider uses get_compatible_custom_providers which already exists in hermes_cli/config.py.
• Related: fix(acp): split custom:name/model and provider/model model names (#53545) #53558 addresses a similar parsing issue for / (slash) syntax in ACP model names. This PR is complementary (different delimiter, same root concern).

[teknium1]

Thanks for the focused parser fix. The reported truncation is present on current main: hermes_cli/models.py:1748-1753 unconditionally parses every nonempty custom:name:model value as a named provider, and ACP passes its selected value through that parser at acp_adapter/server.py:652-658.

Problems

• The new parser tests mock _is_registered_custom_provider, so they do not prove the new configuration integration works. The production helper calls get_compatible_custom_providers(), which supports both legacy custom_providers and v12 keyed providers entries (hermes_cli/config.py:4910-4957). A mismatch in its name/provider_key lookup would silently break the documented named-provider syntax.

Suggested changes

• Add one temp-HERMES_HOME integration test with a real configured named provider, asserting custom:<name>:<model> selects it and an unregistered colon-tag input remains custom plus the full model id.

Automated hermes-sweeper review.

[starm2010]

Thanks for the review — great catch. The unit tests indeed mocked _is_registered_custom_provider, which meant the integration with get_compatible_custom_providers() and the real config.yaml path was never exercised.

I've added 3 integration tests (TestParseModelInputIntegration) that use a real HERMES_HOME with config.yaml containing named custom providers — no mocks on _is_registered_custom_provider:

1. test_named_custom_provider_resolves: config.yaml with a custom_providers list entry named ollama-local. Asserts custom:ollama-local:qwen3-coder → ("custom:ollama-local", "qwen3-coder") — the full get_compatible_custom_providers → load_config → config.yaml path runs.

2. test_unregistered_name_keeps_full_model_id: empty custom_providers list. Asserts custom:glm-5.2:cloud → ("custom", "glm-5.2:cloud") — the Ollama tag colon is preserved, not truncated.

3. test_named_provider_via_providers_key: uses the v12+ keyed providers: schema (not legacy custom_providers). Verifies get_compatible_custom_providers() discovers the named provider from the keyed dict too.

All 19 tests pass (16 original unit + 3 new integration).

[starm2010]

Friendly ping — the integration tests requested in the sweeper review (TestParseModelInputIntegration with a real HERMES_HOME + config.yaml, no mocks on _is_registered_custom_provider) have been pushed. All 19 tests pass (16 unit + 3 integration). Would appreciate a re-review to confirm the get_compatible_custom_providers() → load_config → config.yaml path is now properly covered.