fix(acp): split custom:name/model and provider/model model names (#53545) - #53558
fix(acp): split custom:name/model and provider/model model names (#53545)#53558Tranquil-Flow wants to merge 1 commit into
Conversation
|
Thanks for the focused ACP fix. The reported behavior is still present on the inspected main: No correctness issue was identified from source and diff review. Both ACP switch paths share this resolver ( Automated hermes-sweeper review. |
1107d27 to
0ff0016
Compare
0ff0016 to
48c91ad
Compare
What
Fix model name parsing in ACP's
_resolve_model_selectionto correctly split provider/model when separated by/(in addition to existing colon:syntax).Two bugs addressed (#53545):
custom:name/model — Older code handled
custom:name:model(colon) viaparse_model_input, but external ACP clients like Multica sendcustom:zai/glm-5.2(slash). Model name carried through aszai/glm-5.2→ API rejected. Now split when name matches a configured custom provider.provider/model — Native providers sent as
zai/glm-5.2(nocustom:prefix) fell back to default provider with the whole string as model name. Now split when left side is a known provider, right side is non-empty, no colon present, and current provider is not an aggregator (guards OpenRouter'svendor/modelslugs).How Verified
set_session_modelend-to-end test confirms provider routingcustom:zai/glm-5.2(slash) andcustom:zai:glm-5.2(colon) now yield(custom:zai, glm-5.2)Files
acp_adapter/server.py— two pre-parse branches +_is_configured_custom_providerhelpertests/acp/test_server.py— 6 new tests inTestModelNameSlashSplitCompetitor Check
No open PRs reference #53545. No Tranquil-Flow PRs. Topic-overlap search clean.
Auto-published by Moonsong via Path B automated pipeline.