Skip to content

fix(windows): repair missing console script launchers - #54457

Merged
OutThisLife merged 3 commits into
mainfrom
bb/windows-console-launcher-repair
Jun 28, 2026
Merged

fix(windows): repair missing console script launchers#54457
OutThisLife merged 3 commits into
mainfrom
bb/windows-console-launcher-repair

Conversation

@OutThisLife

Copy link
Copy Markdown
Collaborator

Summary

Authorship

  • HexLab98's base repair and test commits were cherry-picked with original authorship preserved.
  • Gille's follow-up placement/quarantine fix was applied as a separate authored commit.

Test plan

  • scripts/run_tests.sh tests/hermes_cli/test_verify_console_scripts.py tests/hermes_cli/test_update_concurrent_quarantine.py::test_quarantine_succeeds_first_attempt -q
  • scripts/run_tests.sh tests/hermes_cli/test_update_concurrent_quarantine.py -q -k test_quarantine_succeeds_first_attempt

HexLab98 and others added 3 commits June 28, 2026 17:01
On Windows, uv pip install -e . can register hermes.exe in package metadata
while the launcher never lands on disk. Detect missing [project.scripts]
shims and reinstall entry points under the existing quarantine path in
hermes update and install.ps1.
Add unit tests for missing-shim detection and repair trigger in
_verify_console_scripts_installed.
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: bb/windows-console-launcher-repair vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 11674 on HEAD, 11670 on base (🆕 +4)

🆕 New issues (4):

Rule Count
unresolved-attribute 2
unsupported-operator 1
unresolved-import 1
First entries
hermes_cli/main.py:7728: [unsupported-operator] unsupported-operator: Operator `/` is not supported between objects of type `Path | None` and `str`
run_agent.py:3040: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
tests/hermes_cli/test_verify_console_scripts.py:9: [unresolved-import] unresolved-import: Cannot resolve imported module `pytest`
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`

✅ Fixed issues (1):

Rule Count
invalid-assignment 1
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`

Unchanged: 6131 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard platform/windows Native Windows-specific behavior or breakage P2 Medium — degraded but workaround exists sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows labels Jun 28, 2026
@OutThisLife
OutThisLife merged commit 16ff1a3 into main Jun 28, 2026
30 checks passed
@OutThisLife
OutThisLife deleted the bb/windows-console-launcher-repair branch June 28, 2026 22:15
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…nsole-launcher-repair

fix(windows): repair missing console script launchers
habarmc1223-sudo pushed a commit to habarmc1223-sudo/hermes-agent-fluxmem that referenced this pull request Jul 8, 2026
…nsole-launcher-repair

fix(windows): repair missing console script launchers
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
…nsole-launcher-repair

fix(windows): repair missing console script launchers
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
…nsole-launcher-repair

fix(windows): repair missing console script launchers
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
…nsole-launcher-repair

fix(windows): repair missing console script launchers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists platform/windows Native Windows-specific behavior or breakage sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants