fix(windows): repair missing console script launchers - #54457
Merged
Conversation
On Windows, uv pip install -e . can register hermes.exe in package metadata while the launcher never lands on disk. Detect missing [project.scripts] shims and reinstall entry points under the existing quarantine path in hermes update and install.ps1.
Add unit tests for missing-shim detection and repair trigger in _verify_console_scripts_installed.
This was referenced Jun 28, 2026
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-attribute |
2 |
unsupported-operator |
1 |
unresolved-import |
1 |
First entries
hermes_cli/main.py:7728: [unsupported-operator] unsupported-operator: Operator `/` is not supported between objects of type `Path | None` and `str`
run_agent.py:3040: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
tests/hermes_cli/test_verify_console_scripts.py:9: [unresolved-import] unresolved-import: Cannot resolve imported module `pytest`
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
✅ Fixed issues (1):
| Rule | Count |
|---|---|
invalid-assignment |
1 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`
Unchanged: 6131 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…nsole-launcher-repair fix(windows): repair missing console script launchers
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
…nsole-launcher-repair fix(windows): repair missing console script launchers
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…nsole-launcher-repair fix(windows): repair missing console script launchers
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…nsole-launcher-repair fix(windows): repair missing console script launchers
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…nsole-launcher-repair fix(windows): repair missing console script launchers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[project.scripts]launchers after Windows installs, including the primary successful editable-install path where Windows: hermes.exe console_script entry point missing after uv pip install -e . #52931 reproduces.Authorship
Test plan
scripts/run_tests.sh tests/hermes_cli/test_verify_console_scripts.py tests/hermes_cli/test_update_concurrent_quarantine.py::test_quarantine_succeeds_first_attempt -qscripts/run_tests.sh tests/hermes_cli/test_update_concurrent_quarantine.py -q -k test_quarantine_succeeds_first_attempt