fix(windows): repair missing hermes.exe after pip install (#52931) - #52940
Closed
HexLab98 wants to merge 2 commits into
Closed
fix(windows): repair missing hermes.exe after pip install (#52931)#52940HexLab98 wants to merge 2 commits into
HexLab98 wants to merge 2 commits into
Conversation
HexLab98
force-pushed
the
fix/windows-missing-hermes-exe-52931
branch
from
June 26, 2026 07:19
0e692c9 to
19ac78a
Compare
HexLab98
force-pushed
the
fix/windows-missing-hermes-exe-52931
branch
from
June 26, 2026 07:34
19ac78a to
3446031
Compare
…ch#52931) On Windows, uv pip install -e . can register hermes.exe in package metadata while the launcher never lands on disk. Detect missing [project.scripts] shims and reinstall entry points under the existing quarantine path in hermes update and install.ps1.
Add unit tests for missing-shim detection and repair trigger in _verify_console_scripts_installed.
HexLab98
force-pushed
the
fix/windows-missing-hermes-exe-52931
branch
from
June 26, 2026 07:38
3446031 to
4faacfa
Compare
19 tasks
Contributor
|
Thanks for jumping on this. I think this PR is the right place for the fix. One missing case I noticed: the verifier should also run after the primary editable install succeeds, before returning. Right now this covers the fallback path, but the support report can happen when the primary install reports success while I opened #53203 with that follow-up change. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On Windows,
uv pip install -e .can registerhermes.exein package metadata (RECORD/entry_points.txt) while the launcher never lands on disk. Users end up withhermes-agent.exeandhermes-acp.exeinvenv\Scripts\, buthermesis not found on PATH afterhermes updateor a fresh install.This PR adds a post-install verification step: read
[project.scripts]frompyproject.toml, check that every expected.exeexists, and retrypip install --reinstall -e .(with the existing Windows quarantine path) if anything is missing.Type of Change
Changes Made
hermes_cli/main.py— add_verify_console_scripts_installed(); call it after_verify_core_dependencies_installed()in the update/install pathscripts/install.ps1— mirror the same check after Windows dependency install; retry entry points before setuptests/hermes_cli/test_verify_console_scripts.py— unit tests for missing-shim detection and repair triggerHow to Test
scripts/run_tests.sh tests/hermes_cli/test_verify_console_scripts.pyhermes update(orscripts/install.ps1) and confirmvenv\Scripts\hermes.exeexists alongsidehermes-agent.exe/hermes-acp.exehermes.exeis manually deleted after install, rerun update — repair should recreate itChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A