fix(cli): show provider in status bar model label - #53620
Open
JuanIsOnline wants to merge 1 commit into
Open
Conversation
Collaborator
Related: #39892 (OPEN desktop equivalent -- disambiguates provider-prefixed model names in desktop model menus) and the merged TUI precedent #12306. This PR applies the same provider/model disambiguation to the CLI/TUI status bar ( |
Contributor
|
Thanks for the focused classic-CLI disambiguation. The current classic path still strips the provider at Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customandautoout of the visible labelcustom:<slug>andcustom_provider:<slug>sourcesopenai-codextocodexfor a shorter status-bar labelWhy
When multiple providers expose the same model ID, the status bar can be ambiguous if it only displays the model name. For example, two configured providers serving
gpt-5.5would both render asgpt-5.5.Tests
scripts/run_tests.sh tests/cli/test_cli_status_bar.py -- -q.venv/bin/python scripts/check-windows-footguns.py cli.py tests/cli/test_cli_status_bar.py.venv/bin/python -m py_compile cli.pyI also started the full
scripts/run_tests.shsuite locally, but did not run it to completion. This fresh checkout hit unrelated local environment failures before this change area, including missing optionalacpimports and local Hermes home permission errors. The focused status-bar suite passed.