fix(desktop): disambiguate provider-prefixed model names

[yinkev]

Summary

• keep friendly model labels for normal model ids
• detect when provider-prefixed ids would collapse to the same friendly name in desktop model menus
• preserve the full provider/model prefix only for those ambiguous rows in the model dropdown and Edit Models dialog

Fixes #39878.

Tests

• npm ci
• cd apps/desktop && npm exec vitest -- run src/lib/model-status-label.test.ts --environment jsdom
• cd apps/desktop && npm exec eslint -- src/lib/model-status-label.ts src/lib/model-status-label.test.ts src/app/shell/model-menu-panel.tsx src/components/model-visibility-dialog.tsx
• cd apps/desktop && npm run type-check
• git diff --check

Duplicate check

• gh search prs --repo NousResearch/hermes-agent --state open '39878 desktop strip model names provider/model duplicate'

[teknium1]

Thanks for the focused desktop fix. The premise remains valid on current main: modelBaseId() strips provider prefixes in apps/desktop/src/lib/model-status-label.ts:41-45, while the affected dropdown and Edit Models renderers consume that normalized label at apps/desktop/src/app/shell/model-menu-panel.tsx:246 and apps/desktop/src/components/model-visibility-dialog.tsx:112.

The PR detects collisions after the existing friendly-label normalization and preserves the raw prefix only for ambiguous rows, while leaving normal labels unchanged. Both current affected render paths are covered by the proposed wiring, and the helper tests cover the collision and preserved-prefix behavior.

Automated hermes-sweeper review.

[yinkev]

Ported the fix onto current main and expanded behavioral coverage.

• Detects friendly labels shared by distinct model IDs.
• Preserves provider prefixes only for ambiguous rows in both the model menu and Edit Models dialog; unique rows keep friendly labels.
• Preserves existing variant tags and date-pin stripping.
• Added helper regressions plus a rendered menu regression.
• Local focused suites: 17 passed; Prettier, ESLint, and narrowed strict TypeScript passed.
• GitHub desktop typecheck/tests and all required checks are passing; Docker jobs are still completing.

Ready for maintainer review once CI settles.

[yinkev]

Portfolio refresh 2026-07-25: rebased onto current main; the focused model-label/rendering tests, ESLint, desktop type-check, diff hygiene, and all required CI checks are green.