Reconnect dashboard PTY chat after socket drops - #52906
Closed
shannonsands wants to merge 2 commits into
Closed
Conversation
Collaborator
shannonsands
marked this pull request as ready for review
June 26, 2026 07:26
Contributor
|
Merged via #52962 — your two commits were cherry-picked onto current main with your authorship preserved in git log (rebase-merge, commit a0dc924). Thanks @shannonsands! The dashboard PTY chat now auto-reconnects on abnormal closes (1006/1001) and resumes the same session via the per-channel breadcrumb file, with fresh=1 for explicit new sessions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fresh=1handling so explicit new-session actions do not resurrect stale sessions/api/ptyregression coverage for channel resume and fresh startsWhy
The dashboard currently treats unexpected PTY socket drops like terminal session endings. On mobile/background tab interruptions, the browser reports code 1006, the server tears down the PTY child, and the user is left with a dead embedded chat. Remembering the active TUI session per channel lets the reconnect path restore the same conversation instead of starting blank.
Validation