Keep dashboard chat alive across reconnects - #47297
Closed
ljubomirj wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 24, 2026
Closed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the dashboard chat session alive across transient browser WebSocket disconnects, such as laptop sleep/wake or network loss.
This changes
/api/ptyownership so an abnormal WebSocket close parks the PTY bridge for a bounded reconnect window instead of immediately closing thehermes --tuichild. The browser chat tab now retries the PTY WebSocket with bounded exponential backoff and reuses the same stable channel id, so reconnecting can reclaim the running TUI session and its history.Details
1006/1005) alive for reconnect, while intentional page teardown (1000) still closes normally.WebSocket.onopenbefore sending resize data or announcing reconnect success.Validation
python3 -m py_compile hermes_cli/web_server.py tui_gateway/server.pygit diff --cached --check/Users/ljubomir/hermes-agent-macbook2/.venv/bin/python -m pytest tests/hermes_cli/test_web_server.py -k 'reconnectable or TestPtyWebSocket' -q/Users/ljubomir/hermes-agent-macbook2/.venv/bin/python -m pytest tests/test_tui_gateway_server.py -k ws_orphan_reap -q/Users/ljubomir/hermes-agent-macbook2/.venv/bin/python -m ruff check hermes_cli/web_server.py tests/hermes_cli/test_web_server.py tui_gateway/server.pynpm --workspace web run typechecknpm --workspace web run buildnpm --workspace web exec eslint -- src/pages/ChatPage.tsxcompleted with warnings only; no errors.