fix(agent): validate context/memory tool schemas before wrapping (#47707)

[kshitijk4poor]

Summary

One malformed tool schema from a context engine or memory provider no longer disables the entire toolset with an HTTP 400 from strict providers like DeepSeek.

Root cause

agent_init.py wrapped each schema from get_tool_schemas() as {"type": "function", "function": _schema} without validating that _schema has a top-level name. A provider returning an already-wrapped entry ({"type":"function","function":{...}}) would be double-wrapped into a nameless tool. Strict providers reject the entire request with tools[N].function: missing field name (HTTP 400), breaking every turn.

Changes

• agent/memory_manager.py: shared normalize_tool_schema() helper that unwraps already-wrapped entries and returns None for nameless schemas. Wired into all 4 call sites: agent_init context-engine loop + 3 memory_manager surfaces (inject_memory_provider_tools, add_provider routing, get_all_tool_schemas)
• agent/agent_init.py: uses normalize_tool_schema() in the context-engine tool injection loop
• tests/agent/test_memory_provider.py: 9 new tests (unwrap, skip-nameless, non-dict, non-string-name, good+bad alongside, real injection path)

Validation

• 9 new tests pass
• Clean cherry-pick, no conflicts

Salvaged from #47712 by @Bartok9.

Closes #47707

[github-actions]

🔎 Lint report: salvage/47707-tool-schema-validation vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 11197 on HEAD, 11197 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 5916 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

[alt-glitch]

This was generated by AI during triage.

Related: this is a salvage of #47712 (@Bartok9) for issue #47707, which has a saturated competing-fix cluster: #47712 (same files/scope), #47721 (context-engine-only), #47732 (unwrap variant), #48065 (agent_init.py-only subset). #49437 was already closed as a dup of #47712. Flagging for a maintainer to pick the canonical PR; the normalize_tool_schema fix is not yet on main.

[Bartok9]

Thanks for the triage map @alt-glitch — happy to consolidate. Quick case for this one as canonical:

• Shared helper, all 4 call sites. normalize_tool_schema() lives in memory_manager.py and is wired into the agent_init context-engine loop and the 3 memory_manager surfaces (inject_memory_provider_tools, add_provider routing, get_all_tool_schemas). The competing PRs each cover a subset: fix(agent): validate context engine tool schemas before wrapping (#47707) #47721 is context-engine-only, fix(agent): unwrap pre-wrapped context-engine tool schemas #48065 is agent_init.py-only, fix(agent): unwrap pre-wrapped tool schemas from context engines and memory providers #47732 is an unwrap variant without the nameless-skip. A malformed schema can enter from any of those paths, so a partial fix still lets the HTTP 400 through.
• Idempotent + defensive: unwraps already-wrapped {type:function,function:{...}} entries, drops nameless/non-dict/non-string-name schemas, returns None to skip rather than poisoning the toolset.
• 9 tests covering unwrap, skip-nameless, non-dict, non-string-name, good+bad alongside, and the real injection path. Clean cherry-pick, MERGEABLE, lint/type deltas zero.

Salvaged from #47712. If a maintainer prefers I rebase onto a different base or fold in anything from #47732's variant, glad to do it.