fix(agent): validate context/memory tool schemas before wrapping (#47707)

[Bartok9]

Summary

• Validate context-engine and memory-provider tool schemas before wrapping them into OpenAI tool form.
• One malformed/already-wrapped schema no longer poisons the entire request (HTTP 400 → whole toolset disabled).

Motivation

Closes #47707.

In agent/agent_init.py, schemas returned by a context engine's get_tool_schemas() were wrapped as {"type": "function", "function": _schema} without validating that _schema has a top-level name. If a provider returns an entry already in OpenAI tool form ({"type":"function","function":{...}}), the result is double-wrapped into a tool whose function has no top-level name. Strict providers (e.g. DeepSeek) reject the entire request with tools[N].function: missing field name (HTTP 400), so a single bad tool silently disables the whole toolset and breaks every turn. The tool was also never added to valid_tool_names, so even lenient providers couldn't call it. The same unguarded pattern lived in agent/memory_manager.py.

Fix

Add a shared normalize_tool_schema() helper in memory_manager.py that:

• unwraps an already-wrapped OpenAI tool entry to its inner function schema, and
• returns None for anything lacking a resolvable top-level string name.

Wire it into:

• the agent_init.py context-engine injection loop (skip-with-warning instead of appending a nameless tool),
• inject_memory_provider_tools(),
• MemoryManager.add_provider() routing index, and
• MemoryManager.get_all_tool_schemas().

So a single bad plugin schema is skipped (or, if merely double-wrapped but otherwise valid, correctly unwrapped) instead of poisoning the request, with a clear log line pointing at the offending provider.

Verification

• python3 -m pytest tests/agent/test_memory_provider.py — 100 passed (incl. 9 new)
• python3 -m pytest tests/agent/ -k "memory or tool_schema or context_engine or inject" — 209 passed
• ruff check agent/memory_manager.py agent/agent_init.py — clean
• New regression tests assert the unwrap + skip-nameless behavior and fail without the fix (the old blind-wrap path produced a nameless function).

Real behavior proof

• Behavior addressed: an already-wrapped schema {"type":"function","function":{"name":"x_grep",...}} was blind-wrapped a second time into {"type":"function","function":{"type":"function","function":{...}}} — a tool whose function has no top-level name → DeepSeek HTTP 400.
• Real environment: Python 3.14, repo checkout on fix/47707-validate-context-tool-schema.
• Captured output (real run on this branch):

=== BEFORE fix: blind wrap of already-wrapped schema (DeepSeek 400 trigger) ===
{
"type": "function",
"function": {
"type": "function",
"function": {
"name": "x_grep",
...
}
}
}
-> tool.function has top-level 'name'?: False

=== AFTER fix: normalize then wrap ===
{
"type": "function",
"function": {
"name": "x_grep",
"description": "grep X",
"parameters": {"type": "object", "properties": {}}
}
}
-> tool.function has top-level 'name'?: True

• Regression test: tests/agent/test_memory_provider.py::TestMemoryInjectionRejectsMalformedSchema::test_already_wrapped_schema_is_unwrapped_not_poisoned (+ test_nameless_schema_is_skipped, test_good_schema_still_injected_alongside_bad, and TestNormalizeToolSchema).
• What was NOT tested: live end-to-end against a real DeepSeek endpoint (the 400 is reproduced structurally via the wrapped-schema shape, not a network call).

[teknium1]

Thanks for the thorough fix. This is an automated hermes-sweeper review: the exact implementation has already landed on main via the salvaged PR #52140, retaining the original author credit.

• 710cd48fb1d649925e159aa08d29993f828c40ee adds the same three-file +177/-16 change and is an ancestor of current main.
• agent/memory_manager.py:49 normalizes wrapped schemas and rejects malformed entries; agent/agent_init.py:1939 applies it to context-engine schema injection.
• tests/agent/test_memory_provider.py:1503 and :1561 retain the unwrap, reject, and injection regression coverage.
• The related fix(agent): validate context/memory tool schemas before wrapping (#47707) #52140 discussion explicitly records it as a salvage of this PR; fix(agent): validate tool schemas from context engines and memory providers before wrapping #49437 was previously closed as a duplicate of fix(agent): validate context/memory tool schemas before wrapping (#47707) #47712.