Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions tests/tools/test_browser_console.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,40 @@ def test_browser_vision_defaults_temperature_when_config_omits_it(self, tmp_path
assert mock_llm.call_args.kwargs["temperature"] == 0.1
assert mock_llm.call_args.kwargs["timeout"] == 120.0

def test_browser_vision_defaults_nonfinite_config(self, tmp_path):
from tools.browser_tool import browser_vision

shots_dir, screenshot = self._setup_screenshot(tmp_path)
mock_response = MagicMock()
mock_choice = MagicMock()
mock_choice.message.content = "Default finite screenshot analysis"
mock_response.choices = [mock_choice]

with (
patch("hermes_constants.get_hermes_dir", return_value=shots_dir),
patch("tools.browser_tool._cleanup_old_screenshots"),
patch(
"tools.browser_tool._run_browser_command",
return_value={"success": True, "data": {"path": str(screenshot)}},
),
patch("tools.browser_tool._get_vision_model", return_value="test-model"),
patch(
"hermes_cli.config.load_config",
return_value={
"auxiliary": {
"vision": {"temperature": "nan", "timeout": "inf"}
}
},
),
patch("tools.browser_tool.call_llm", return_value=mock_response) as mock_llm,
):
result = json.loads(browser_vision("what is on the page?", task_id="test"))

assert result["success"] is True
assert result["analysis"] == "Default finite screenshot analysis"
assert mock_llm.call_args.kwargs["temperature"] == 0.1
assert mock_llm.call_args.kwargs["timeout"] == 120.0

def test_browser_vision_native_fast_path_returns_multimodal(self, tmp_path):
"""supports_vision override → screenshot attached natively, no aux call."""
from agent.auxiliary_client import clear_runtime_main, set_runtime_main
Expand Down
14 changes: 12 additions & 2 deletions tools/browser_tool.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
import functools
import json
import logging
import math
import os
import re
import subprocess
Expand Down Expand Up @@ -113,6 +114,15 @@

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend this finite-value handling to the sibling auxiliary.vision consumers in tools/vision_tools.py (1236-1239 for image analysis and 1739-1742 for video analysis). They still pass nan/inf through direct float(...) conversions.

logger = logging.getLogger(__name__)


def _finite_float(value: Any, default: float) -> float:
try:
parsed = float(value)
except (TypeError, ValueError, OverflowError):
return default
return parsed if math.isfinite(parsed) else default


# Standard PATH entries for environments with minimal PATH (e.g. systemd services).
# Includes Android/Termux and macOS Homebrew locations needed for agent-browser,
# npx, node, and Android's glibc runner (grun).
Expand Down Expand Up @@ -3401,10 +3411,10 @@ def browser_vision(question: str, annotate: bool = False, task_id: Optional[str]
_vision_cfg = cfg_get(_cfg, "auxiliary", "vision", default={})
_vt = _vision_cfg.get("timeout")
if _vt is not None:
vision_timeout = float(_vt)
vision_timeout = _finite_float(_vt, 120.0)
_vtemp = _vision_cfg.get("temperature")
if _vtemp is not None:
vision_temperature = float(_vtemp)
vision_temperature = _finite_float(_vtemp, 0.1)
except Exception:
pass

Expand Down