fix(browser): default non-finite vision config - #51981
Open
lin-hongkuan wants to merge 1 commit into
Open
lin-hongkuan wants to merge 1 commit into
lin-hongkuan wants to merge 1 commit into
Conversation
teknium1
reviewed
Jul 15, 2026
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for addressing the non-finite configuration case. The browser_vision change itself matches the current defect at tools/browser_tool.py:4118-4121 and the new test exercises the intended fallback.
Problems
- The same
auxiliary.visiontimeout/temperature parsing remains unguarded in image vision attools/vision_tools.py:1236-1239and video vision attools/vision_tools.py:1739-1742. Those paths pass the converted values to their LLM calls, sonan/infremains accepted outsidebrowser_vision.
Suggested changes
- Apply finite-value validation to both
tools/vision_tools.pypaths, retaining their existing defaults, and add matching regression coverage.
Automated hermes-sweeper review.
| @@ -113,6 +114,15 @@ | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
Please extend this finite-value handling to the sibling auxiliary.vision consumers in tools/vision_tools.py (1236-1239 for image analysis and 1739-1742 for video analysis). They still pass nan/inf through direct float(...) conversions.
This was referenced Aug 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infandnanTests
python -m pytest tests/tools/test_browser_console.py::TestBrowserVisionConfig::test_browser_vision_defaults_nonfinite_config -qpython -m pytest tests/tools/test_browser_console.py::TestBrowserVisionConfig -qpython -m pytest tests/tools/test_browser_console.py -q(fails on Windows due existing default-encoding reads of SKILL.md in TestDogfoodSkill; targeted browser vision tests pass)python -m py_compile tools/browser_tool.pypython scripts/check-windows-footguns.py --all