Add configurable Feishu thread replies - #51544
Closed
patrick-fu wants to merge 1 commit into
Closed
Conversation
- Add a Feishu reply_in_thread setting backed by FEISHU_REPLY_IN_THREAD for forced threaded replies. - Route Feishu progress and status messages through the triggering message when forced thread replies are enabled. - Cover the configured reply_in_thread send path with an adapter regression test.
patrick-fu
force-pushed
the
p/patrick/feishu-reply-in-thread
branch
from
June 23, 2026 21:08
83e9662 to
0bb12c8
Compare
patrick-fu
marked this pull request as ready for review
June 23, 2026 21:09
Collaborator
7 tasks
Contributor
|
Thanks for the focused Feishu routing work and regression coverage. This automated hermes-sweeper review is closing this under the standing configuration policy:
A config.yaml-only re-scope is welcome for maintainer review. Closed as not-planned per standing maintainer policy ( Closed as not-planned per standing maintainer policy ( |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt-in Feishu/Lark
reply_in_threadsetting so operators can keep bot replies and intermediate gateway messages inside Feishu topic replies instead of flooding the main chat.Why
Feishu only keeps a message in a topic when the reply API is used with
reply_in_thread=true. Existing routing already handles messages that originate inside an explicit topic, but @mentions from the main chat and some progress/status paths do not have thread metadata and can remain as top-level chat messages.Changes
reply_in_threadtoFeishuAdapterSettings, sourced from Feishu platform config orFEISHU_REPLY_IN_THREAD.reply_in_thread=true.Related
Validation
venv/bin/python -m py_compile gateway/run.py plugins/platforms/feishu/adapter.py tests/gateway/test_feishu.pyvenv/bin/python -m unittest tests.gateway.test_feishu.TestAdapterBehavior.test_send_replies_in_thread_when_thread_metadata_present tests.gateway.test_feishu.TestAdapterBehavior.test_send_replies_in_thread_when_config_enabled tests.gateway.test_feishu.TestAdapterBehavior.test_send_uses_metadata_reply_target_for_threaded_feishu_topicgit diff --check