[codex] Add Feishu thread reply toggle - #33307
Closed
T0UGH wants to merge 1 commit into
Closed
Conversation
T0UGH
marked this pull request as ready for review
May 27, 2026 15:20
Author
|
@teknium1 Could you approve the pending workflows for this fork PR when you have a moment? The change is small and scoped to a Feishu reply-thread toggle, with targeted tests included. Thanks. |
7 tasks
Contributor
|
Thanks for the focused implementation and regression coverage. This automated hermes-sweeper review is closing this under the standing configuration policy:
A config.yaml-only re-scope is welcome for maintainer review. Closed as not-planned per standing maintainer policy ( |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Feishu/Lark
reply_in_threadsetting so deployments can choose whether messages that originate from Feishu topics/threads should receive threaded replies or top-level chat replies.Root cause
The Feishu adapter inferred
reply_in_thread=Truewhenever inbound metadata contained athread_id. It also usedthread_idas the create-message receive target during fallback. That made topic replies unconditional, even for deployments that want the bot to answer directly in the parent chat.Changes
reply_in_threadfrom Feishu platform config orFEISHU_REPLY_IN_THREAD, defaulting to the existing threaded behavior.reply_in_threadis disabled.FEISHU_REPLY_IN_THREADandfeishu.reply_in_thread.Validation
python -m pytest tests/gateway/test_feishu.py -k "reply_in_thread or threaded_feishu_topic"git diff --check