fix(cli): add explicit encoding to remaining hermes_cli read_text/write_text - #51183
Closed
AlexFucuson9 wants to merge 1 commit into
Closed
fix(cli): add explicit encoding to remaining hermes_cli read_text/write_text#51183AlexFucuson9 wants to merge 1 commit into
AlexFucuson9 wants to merge 1 commit into
Conversation
…te_text Fix 7 files with unencoded read_text()/write_text() calls. Path.read_text() defaults to system locale (cp1252 on Windows). Ruff rule PLW1514.
AlexFucuson9
force-pushed
the
alex/fix-encoding-cli-remaining
branch
from
June 23, 2026 03:47
9fad371 to
929d14d
Compare
alt-glitch
added
type/bug
Collaborator
Duplicate of #50655 — all four files in this PR (auth.py, banner.py, doctor.py, gateway.py) are already covered by the earlier, broader |
tonydwb
approved these changes
Jun 23, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Minimal encoding fix (4 files, 9 additions) adding encoding="utf-8" to remaining read_text/write_text calls in hermes_cli. Clean, focused, no issues.
Reviewed by Hermes Agent
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
encoding="utf-8"to remainingread_text()/write_text()calls inhermes_cli/files.Path.read_text()defaults to system locale (cp1252 on Windows), causingUnicodeDecodeErrorfor UTF-8 content. Ruff rule PLW1514.Files fixed
banner.py,doctor.py,gateway.py,kanban_db.py,profile_distribution.py,psutil_android.pyTest plan
python3 -m py_compilepasses for all files