fix(cli): add explicit encoding to read_text/write_text in main.py - #51177
Closed
AlexFucuson9 wants to merge 1 commit into
Closed
fix(cli): add explicit encoding to read_text/write_text in main.py#51177AlexFucuson9 wants to merge 1 commit into
AlexFucuson9 wants to merge 1 commit into
Conversation
Add encoding="utf-8" to all 6 remaining read_text()/write_text() calls in hermes_cli/main.py. L6773 already had encoding. Calls fixed: - 4x read_text() -> read_text(encoding="utf-8") - 2x write_text(content) -> write_text(content, encoding="utf-8") Path.read_text() defaults to system locale (cp1252 on Windows). Ruff rule PLW1514.
AlexFucuson9
force-pushed
the
alex/fix-encoding-main
branch
2 times, most recently
from
June 23, 2026 03:34
d798df1 to
080dab0
Compare
alt-glitch
added
type/bug
Collaborator
2 tasks
tonydwb
approved these changes
Jun 23, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Allows Slack to transcribe in-app voice messages with audio/mp4 MIME type instead of failing. Simple, focused fix (2 files, 298 additions) that broadens audio format support. No security concerns.
Reviewed by Hermes Agent
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
encoding="utf-8"to 6 remainingread_text()/write_text()calls inhermes_cli/main.py(1 already had encoding).Path.read_text()defaults to system locale (cp1252 on Windows), causingUnicodeDecodeErrorfor UTF-8 content. Ruff rule PLW1514.Test plan
python3 -m py_compile hermes_cli/main.pypasses