fix(desktop): show tooltips on all statusbar item variants - #49625
Closed
alelpoan wants to merge 2 commits into
Closed
fix(desktop): show tooltips on all statusbar item variants#49625alelpoan wants to merge 2 commits into
alelpoan wants to merge 2 commits into
Conversation
Collaborator
|
Duplicate of #43077 — both forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Statusbar items (Terminal, YOLO, Gateway, Agents, Cron, version, timers) all had
titlestrings defined inuseStatusbarItems, but thetitleprop was never forwarded to the underlying HTML elements inStatusbarItemView. As a result, no tooltips appeared on hover making it hard to discover what each icon/button does without prior knowledge.(e.g. the terminal toggle was undiscoverable without prior knowledge personally spent 20 minutes looking for it before finding it via the agent)
Related Issue
Fixes #
Type of Change
Changes Made
apps/desktop/src/app/shell/statusbar-controls.tsx: addedtitle={item.title}to the<button>(action variant) and<div>(text variant) render branches in
StatusbarItemViewHow to Test
running timer, context usage, session timer)
Checklist
Code
pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Before

After

