fix(desktop): pass title attribute to statusbar item render paths for hover tooltips - #43077
Closed
liuhao1024 wants to merge 1 commit into
Closed
fix(desktop): pass title attribute to statusbar item render paths for hover tooltips#43077liuhao1024 wants to merge 1 commit into
liuhao1024 wants to merge 1 commit into
Conversation
… hover tooltips
The StatusbarItem interface defines a title property, but StatusbarItemView
never forwarded it to the rendered <button> or <a> elements. This caused
statusbar items (YOLO, Gateway, model switcher, etc.) to show no tooltip
on hover.
Add title={item.title} to all three interactive render paths:
- Menu trigger button (variant='menu')
- Link element (href/variant='link')
- Action button (default)
19 tasks
19 tasks
Contributor
|
Thanks for the focused statusbar-tooltip fix. This is already implemented on current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Passes the
titleattribute fromStatusbarItemto the rendered<button>and<a>elements inStatusbarItemView, enabling native hover tooltips on all interactive statusbar items (YOLO, Gateway, model switcher, version, etc.).Related Issue
Fixes #43071
Type of Change
Changes Made
apps/desktop/src/app/shell/statusbar-controls.tsx: Addedtitle={item.title}to the three interactive render paths inStatusbarItemView— menu trigger button, link element, and action button. TheStatusbarIteminterface already definestitle?: string, so no type changes were needed.How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/ACode Intelligence
StatusbarItemViewinstatusbar-controls.tsx(4 render paths: menu, text, link, action button)StatusbarItem.titleis already defined in the interface and populated by statusbar item producers; this PR closes the gap where the consumer (StatusbarItemView) didn't forward it to the DOM