Skip to content

fix(desktop): pass title attribute to statusbar item render paths for hover tooltips - #43077

Closed
liuhao1024 wants to merge 1 commit into
NousResearch:mainfrom
liuhao1024:fix/desktop-statusbar-title-tooltip
Closed

fix(desktop): pass title attribute to statusbar item render paths for hover tooltips#43077
liuhao1024 wants to merge 1 commit into
NousResearch:mainfrom
liuhao1024:fix/desktop-statusbar-title-tooltip

Conversation

@liuhao1024

Copy link
Copy Markdown
Contributor

What does this PR do?

Passes the title attribute from StatusbarItem to the rendered <button> and <a> elements in StatusbarItemView, enabling native hover tooltips on all interactive statusbar items (YOLO, Gateway, model switcher, version, etc.).

Related Issue

Fixes #43071

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

  • apps/desktop/src/app/shell/statusbar-controls.tsx: Added title={item.title} to the three interactive render paths in StatusbarItemView — menu trigger button, link element, and action button. The StatusbarItem interface already defines title?: string, so no type changes were needed.

How to Test

  1. Open Hermes Desktop
  2. Hover over any statusbar item (YOLO bolt, version number, cron clock, Gateway indicator, model switcher, etc.)
  3. A native tooltip should appear showing the item's title text (e.g., "YOLO: Off", "Gateway", "Switch model")
  4. Verify tooltips appear on all three render paths: menu items (e.g., cron dropdown), link items (e.g., version), and button items (e.g., YOLO, model switcher)

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: macOS

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Code Intelligence

  • Analyzed: StatusbarItemView in statusbar-controls.tsx (4 render paths: menu, text, link, action button)
  • Blast radius: LOW — pure DOM attribute addition, no logic changes
  • Related patterns: StatusbarItem.title is already defined in the interface and populated by statusbar item producers; this PR closes the gap where the consumer (StatusbarItemView) didn't forward it to the DOM

… hover tooltips

The StatusbarItem interface defines a title property, but StatusbarItemView
never forwarded it to the rendered <button> or <a> elements. This caused
statusbar items (YOLO, Gateway, model switcher, etc.) to show no tooltip
on hover.

Add title={item.title} to all three interactive render paths:
- Menu trigger button (variant='menu')
- Link element (href/variant='link')
- Action button (default)
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused statusbar-tooltip fix. This is already implemented on current main with the Desktop tooltip component, so the PR is superseded. This is an automated hermes-sweeper review.

  • apps/desktop/src/app/shell/statusbar-controls.tsx:119-125 composes the menu trigger with TooltipContent>{item.title}</TooltipContent; the text, link, and action branches use Tip label={item.title} at lines 179, 194, and 203.
  • apps/desktop/src/components/ui/tooltip.tsx:74-90 defines Tip as the project's instant hover-tooltip wrapper.
  • da73223f4aba9beee9c020a5fee02f243414a3d7 implemented statusbar hover tooltips, and 7a6b3cb923f1fa99260b909e3729c35e6ffee323 completed the menu-trigger path. The implementation shipped in v2026.7.1.
  • The linked issue Title attribute not passed to statusbar elements — no hover tooltips #43071 was closed with the same verified implementation.

@teknium1 teknium1 closed this Jul 14, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Title attribute not passed to statusbar elements — no hover tooltips

3 participants