fix(gateway): refresh runtime max_turns before agent creation - #48127
Closed
infinitycrew39 wants to merge 4 commits into
Closed
fix(gateway): refresh runtime max_turns before agent creation#48127infinitycrew39 wants to merge 4 commits into
infinitycrew39 wants to merge 4 commits into
Conversation
alt-glitch
added
type/bug
Collaborator
|
Related: #32544 — both fix stale |
When a gateway agent is reused from cache, it retains the max_iterations from its initial creation. If config.yaml agent.max_turns or HERMES_MAX_ITERATIONS changed between turns, the cached agent's budget becomes stale. Before reusing a cached agent, refresh agent.max_iterations from the freshly-resolved value (read from env/config at line 14585). Fixes partial issue from PR NousResearch#48127: handles fresh agent creation + cached agent reuse.
Add 5 test cases covering: - Cached agent max_iterations refreshed from HERMES_MAX_ITERATIONS env - Refresh works even for interrupt-recursive turns (depth > 0) - Session state is preserved during refresh - Integration: env config changes propagate to cached agent on reuse Tests can be run via: scripts/run_tests.sh tests/gateway/test_cached_agent_max_iterations.py Fix: correct static method access in fixture (remove __func__)
infinitycrew39
force-pushed
the
fix/max-turns-runtime-budget
branch
from
June 19, 2026 04:08
5f83677 to
6915c9a
Compare
teknium1
pushed a commit
that referenced
this pull request
Jun 19, 2026
When a gateway agent is reused from cache, it retains the max_iterations from its initial creation. If config.yaml agent.max_turns or HERMES_MAX_ITERATIONS changed between turns, the cached agent's budget becomes stale. Before reusing a cached agent, refresh agent.max_iterations from the freshly-resolved value (read from env/config at line 14585). Fixes partial issue from PR #48127: handles fresh agent creation + cached agent reuse.
Contributor
|
Merged via PR #48834 — your two fix commits were cherry-picked onto current main with your authorship preserved (rebase-merge). The tautological cached-agent test was swapped for one that exercises the real contracts. Live-validated against origin/main: a cache-reused agent was stuck at 90 despite config.yaml max_turns=200; the fix refreshes it to 200. Thanks for the fix and the clear root-cause writeup! #48834 |
xyshanren
pushed a commit
to xyshanren/hermes-agent-cn
that referenced
this pull request
Jun 25, 2026
When a gateway agent is reused from cache, it retains the max_iterations from its initial creation. If config.yaml agent.max_turns or HERMES_MAX_ITERATIONS changed between turns, the cached agent's budget becomes stale. Before reusing a cached agent, refresh agent.max_iterations from the freshly-resolved value (read from env/config at line 14585). Fixes partial issue from PR NousResearch#48127: handles fresh agent creation + cached agent reuse.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
When a gateway agent is reused from cache, it retains the max_iterations from its initial creation. If config.yaml agent.max_turns or HERMES_MAX_ITERATIONS changed between turns, the cached agent's budget becomes stale. Before reusing a cached agent, refresh agent.max_iterations from the freshly-resolved value (read from env/config at line 14585). Fixes partial issue from PR NousResearch#48127: handles fresh agent creation + cached agent reuse.
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
When a gateway agent is reused from cache, it retains the max_iterations from its initial creation. If config.yaml agent.max_turns or HERMES_MAX_ITERATIONS changed between turns, the cached agent's budget becomes stale. Before reusing a cached agent, refresh agent.max_iterations from the freshly-resolved value (read from env/config at line 14585). Fixes partial issue from PR NousResearch#48127: handles fresh agent creation + cached agent reuse.
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
When a gateway agent is reused from cache, it retains the max_iterations from its initial creation. If config.yaml agent.max_turns or HERMES_MAX_ITERATIONS changed between turns, the cached agent's budget becomes stale. Before reusing a cached agent, refresh agent.max_iterations from the freshly-resolved value (read from env/config at line 14585). Fixes partial issue from PR NousResearch#48127: handles fresh agent creation + cached agent reuse.
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
When a gateway agent is reused from cache, it retains the max_iterations from its initial creation. If config.yaml agent.max_turns or HERMES_MAX_ITERATIONS changed between turns, the cached agent's budget becomes stale. Before reusing a cached agent, refresh agent.max_iterations from the freshly-resolved value (read from env/config at line 14585). Fixes partial issue from PR NousResearch#48127: handles fresh agent creation + cached agent reuse.
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
When a gateway agent is reused from cache, it retains the max_iterations from its initial creation. If config.yaml agent.max_turns or HERMES_MAX_ITERATIONS changed between turns, the cached agent's budget becomes stale. Before reusing a cached agent, refresh agent.max_iterations from the freshly-resolved value (read from env/config at line 14585). Fixes partial issue from PR NousResearch#48127: handles fresh agent creation + cached agent reuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a runtime budget bug where long-lived gateway and api_server processes could continue using a stale 90-turn iteration cap even after
agent.max_turnswas increased inconfig.yaml.The root cause was that some request paths read
HERMES_MAX_ITERATIONSbefore refreshing the config-authoritative runtime env, whileapi_serverbypassed that refresh path entirely.Type of Change
Changes Made
gateway/run.pythat refreshes config/.env before resolving the current iteration budget.gateway/platforms/api_server.pyto use the same helper instead of reading a stale env snapshot directly.How to Test
HERMES_MAX_ITERATIONS=90.agent.max_turns: 200in~/.hermes/config.yamlwithout restarting the process.Notes
Targeted pytest execution was not possible in this workspace because no project virtualenv is present; modified files were validated with
python3 -m py_compile.