fix(gateway): preserve max_turns after env reload (salvage #19183) - #21240
Merged
Conversation
alt-glitch
added
type/bug
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19183 via salvage. Fixes #19158.
Summary
Gateway re-reads
~/.hermes/.envevery turn to pick up rotated API keys.HERMES_MAX_ITERATIONSbridged fromagent.max_turnsat startup would silently revert to a stale value from .env on every subsequent turn.Add
_reload_runtime_env_preserving_config_authority()that reloads .env then re-appliesagent.max_turnsfromconfig.yamlintoHERMES_MAX_ITERATIONS, keeping config.yaml authoritative.Validation
scripts/run_tests.sh tests/gateway/test_runtime_env_reload_config_authority.py→ 2 passed.Original author: @altmazza0-star.