fix(honcho): auto-enable honcho toolset when configured - #4553
Closed
Bartok9 wants to merge 1 commit into
Closed
Conversation
…#4523) When users have explicit `platform_toolsets` configured in config.yaml (created by running `hermes tools`), the Honcho tools were missing from the tool surface despite Honcho being active and context injection working. This happened because `honcho` is not in `CONFIGURABLE_TOOLSETS`, so it was excluded when `_get_platform_tools()` resolved which toolsets to enable. This fix adds logic to auto-inject the `honcho` toolset when a valid HonchoClientConfig exists (enabled=True with api_key or base_url set), following the same pattern used for plugin toolsets. - Add honcho auto-enable check in `_get_platform_tools()` - Add tests for honcho auto-enable behavior - Ensure honcho is available on all platforms when configured Fixes NousResearch#4523
Bartok9
force-pushed
the
fix/honcho-toolset-auto-enable
branch
from
April 4, 2026 07:41
8fed983 to
8a1c0ae
Compare
Contributor
Author
|
Superseded by #14408 — rebased onto current main with full coverage. |
alt-glitch
added
type/bug
Collaborator
|
Superseded by #14408 (rebased version). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When users have explicit
platform_toolsetsconfigured in config.yaml (created by runninghermes tools), the Honcho tools (honcho_context,honcho_profile,honcho_search,honcho_conclude) were missing from the tool surface despite Honcho being active and context injection working correctly.Root Cause
The
honchotoolset is defined intoolsets.pybut is not inCONFIGURABLE_TOOLSETSinhermes_cli/tools_config.py. When_get_platform_tools()resolves which toolsets to enable for a platform, it only considersCONFIGURABLE_TOOLSETSentries (plus plugin toolsets). Sincehonchois not in either list, it was excluded fromenabled_toolsets.Fix
Auto-inject the
honchotoolset in_get_platform_tools()when a valid Honcho config exists (enabled=True with api_key or base_url set), following the same pattern used for plugin toolsets.Changes
_get_platform_tools()after plugin toolset handlingTesting
All new tests pass:
Fixes #4523