fix(honcho): auto-enable honcho toolset when configured (rebased) - #14408
fix(honcho): auto-enable honcho toolset when configured (rebased)#14408Bartok9 wants to merge 1 commit into
Conversation
When a user runs `hermes tools` to customize their toolset config, platform_toolsets becomes explicit and the honcho toolset is silently dropped — even if the user ran `hermes honcho setup` and has a valid configuration. Fix: check for a configured HonchoClientConfig and auto-add 'honcho' to enabled_toolsets, mirroring the existing auto-enable logic for plugins. Import is guarded in try/except so no breakage when honcho is not installed. Fixes NousResearch#4523
|
Thanks for the contribution and the rebase effort, @Bartok9! This is an automated hermes-sweeper review. Unfortunately the fix's premise is no longer valid on
Adding a guard in |
Problem
Rebased version of #4553.
After running
hermes toolsto customize toolsets,platform_toolsetsbecomes an explicit dict and honcho is silently dropped from the active toolset — even if the user previously ranhermes honcho setup.Root Cause
Honcho is not in
CONFIGURABLE_TOOLSETS(it is configured viahermes honcho setup), so it is not included when toolsets are resolved from an explicit config.Fix
Added a guard in
_get_platform_tools()that checks for a validHonchoClientConfigand auto-adds honcho to the enabled set, mirroring the existing auto-enable logic for plugins. Import is guarded in try/except — no breakage if honcho is not installed.Changes
hermes_cli/tools_config.pySupersedes #4553.