Skip to content

fix(honcho): auto-enable honcho toolset when configured (rebased) - #14408

Closed
Bartok9 wants to merge 1 commit into
NousResearch:mainfrom
Bartok9:fix/honcho-auto-enable-v2
Closed

fix(honcho): auto-enable honcho toolset when configured (rebased)#14408
Bartok9 wants to merge 1 commit into
NousResearch:mainfrom
Bartok9:fix/honcho-auto-enable-v2

Conversation

@Bartok9

@Bartok9 Bartok9 commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Problem

Rebased version of #4553.

After running hermes tools to customize toolsets, platform_toolsets becomes an explicit dict and honcho is silently dropped from the active toolset — even if the user previously ran hermes honcho setup.

Root Cause

Honcho is not in CONFIGURABLE_TOOLSETS (it is configured via hermes honcho setup), so it is not included when toolsets are resolved from an explicit config.

Fix

Added a guard in _get_platform_tools() that checks for a valid HonchoClientConfig and auto-adds honcho to the enabled set, mirroring the existing auto-enable logic for plugins. Import is guarded in try/except — no breakage if honcho is not installed.

if "honcho" not in enabled_toolsets:
    try:
        from honcho_integration.client import HonchoClientConfig
        hcfg = HonchoClientConfig.from_global_config()
        if hcfg.enabled and (hcfg.api_key or hcfg.base_url):
            enabled_toolsets.add("honcho")
    except Exception:
        pass

Changes

File Change
hermes_cli/tools_config.py Honcho auto-enable guard (12 lines)

Supersedes #4553.

When a user runs `hermes tools` to customize their toolset config,
platform_toolsets becomes explicit and the honcho toolset is silently
dropped — even if the user ran `hermes honcho setup` and has a valid
configuration.

Fix: check for a configured HonchoClientConfig and auto-add 'honcho' to
enabled_toolsets, mirroring the existing auto-enable logic for plugins.
Import is guarded in try/except so no breakage when honcho is not installed.

Fixes NousResearch#4523
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/tools Tool registry, model_tools, toolsets comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 23, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the contribution and the rebase effort, @Bartok9!

This is an automated hermes-sweeper review.

Unfortunately the fix's premise is no longer valid on main. The honcho toolset was intentionally removed from the toolset system as part of PR #4623 (commit 924bc67ee, merged Apr 2 2026), which introduced the pluggable MemoryProvider interface. Honcho is now a memory plugin — its tools (honcho_search, honcho_reasoning, honcho_profile, etc.) are injected and dispatched via MemoryManager, not via _get_platform_tools() or the toolset registry.

  • toolsets.py:196 — explicit comment: # "honcho" toolset removed — Honcho is now a memory provider plugin.
  • run_agent.py:8737 — Honcho tool calls are routed through self._memory_manager.handle_tool_call(), bypassing toolsets entirely
  • hermes_cli/tools_config.py — zero references to honcho on current main

Adding a guard in _get_platform_tools() to auto-enable a honcho toolset key would have no effect since that key no longer exists in TOOLSETS. If Honcho tools are being silently dropped after hermes tools is run, the fix would need to target the MemoryManager activation path (i.e. ensuring memory.provider = honcho is respected when platform_toolsets is explicit). Happy to reopen if you'd like to pursue that angle.

@teknium1 teknium1 closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants