Skip to content

fix(installer): skip node/npm/npx symlinks for user installs (#45279) #45384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kyssta-exe wants to merge 1 commit into from
+11 −4
Closed

fix(installer): skip node/npm/npx symlinks for user installs (#45279) #45384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,10 +846,17 @@ install_node() {

local node_link_dir
node_link_dir="$(get_command_link_dir)"
mkdir -p "$node_link_dir"
ln -sf "$HERMES_HOME/node/bin/node" "$node_link_dir/node"
ln -sf "$HERMES_HOME/node/bin/npm" "$node_link_dir/npm"
ln -sf "$HERMES_HOME/node/bin/npx" "$node_link_dir/npx"
# Only create node/npm/npx symlinks for root/FHS installs where they
# are needed for command resolution from a login shell. For user
# installs (~/.local/bin) the symlinks would shadow the user's own
# Homebrew/nvm node — Hermes invokes its bundled node via absolute
# path in its own subprocesses anyway. (GH-45279)
if [ "$ROOT_FHS_LAYOUT" = true ] || is_termux; then
mkdir -p "$node_link_dir"
ln -sf "$HERMES_HOME/node/bin/node" "$node_link_dir/node"
ln -sf "$HERMES_HOME/node/bin/npm" "$node_link_dir/npm"
ln -sf "$HERMES_HOME/node/bin/npx" "$node_link_dir/npx"
fi

export PATH="$HERMES_HOME/node/bin:$PATH"

Expand Down
Loading