fix(installer): skip node/npm/npx symlinks for user installs (#45279) - #45384
Closed
kyssta-exe wants to merge 1 commit into
Closed
kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
tonydwb
approved these changes
Jun 13, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Clean fix: skip node/npm/npx symlinks for user installs. Prevents incorrect PATH entries when running as a regular user. Well-scoped, minimal diff.
- Logic is correct
- No security concerns
- No debug artifacts
Reviewed by Hermes Agent
Contributor
Author
|
Stale — oldest open PR, no merge activity for weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45279. The installer now only creates node/npm/npx symlinks in the command bin dir for root/FHS and Termux installs. For user installs (~/.local/bin), the symlinks are skipped to avoid shadowing the user's Homebrew/nvm node. Hermes invokes its bundled node via absolute path in its own subprocesses.