fix(tests): drop --profile from cron create options test (missed in #43956 revert) - #43978
Closed
teknium1 wants to merge 1 commit into
Closed
fix(tests): drop --profile from cron create options test (missed in #43956 revert)#43978teknium1 wants to merge 1 commit into
teknium1 wants to merge 1 commit into
Conversation
PR #43956 reverted cron per-job profile support and removed the --profile flag from the parser, but missed this test, leaving main's test (2) shard red (SystemExit: 2, unrecognized arguments).
Contributor
🔎 Lint report:
|
alt-glitch
added
type/test
Collaborator
Contributor
Author
tonydwb
approved these changes
Jun 11, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Looks Good
- Test fix: removes --profile assertions from test_cron_create_options. The --profile option was removed from cron create in PR #43956 but the test assertion was missed. Clean revert of stale assertions.
No Issues Found
- Straightforward test cleanup.
Reviewed by Hermes Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the red
test (2)shard on main: PR #43956 (revert of cron per-job profile support) removed the--profileflag from the cron parser but missedtest_cron_create_options, which still passes--profile workand fails withSystemExit: 2.Changes
tests/hermes_cli/test_subcommands_cron.py: drop--profile workarg andns.profileassertionValidation
test_subcommands_cron.pyInfographic