fix(tests): drop --profile assertions missed by cron profile revert - #43974
Closed
teknium1 wants to merge 1 commit into
Closed
fix(tests): drop --profile assertions missed by cron profile revert#43974teknium1 wants to merge 1 commit into
teknium1 wants to merge 1 commit into
Conversation
PR #43956 removed the cron per-job --profile flag but left test_cron_create_options passing '--profile work' to the parser, breaking main's CI (unrecognized arguments: --profile work).
Contributor
🔎 Lint report:
|
alt-glitch
added
type/test
Contributor
Author
|
Superseded: the --profile cleanup landed on main via the cron parser extraction (test file renamed to test_cron_parser_builder.py with the stale assertions already removed). Closing as redundant. |
tonydwb
approved these changes
Jun 11, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Looks Good
- Test fix: removes --profile assertions from test_cron_create_options. The --profile option was removed from cron create in a prior revert but the test assertion was missed.
Note
- PR #43978 also proposes the same change. One of these should be closed as duplicate.
No Issues Found
- Straightforward test cleanup.
Reviewed by Hermes Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores green CI on main: PR #43956 (revert of cron per-job profile support) removed the
--profileflag fromhermes cron createbut lefttest_cron_create_optionsstill passing--profile workto the parser, so every run since fails withSystemExit: 2 — unrecognized arguments: --profile work.Changes
tests/hermes_cli/test_subcommands_cron.py: drop the orphaned--profile workarg andns.profileassertion.Validation
Infographic