fix(skills): resolve skill_view by frontmatter name when dir name differs - #43323
Merged
kshitijk4poor merged 1 commit intoJun 10, 2026
Conversation
…fers skills_list() surfaces each skill's frontmatter `name:`, but skill_view() only matched on the on-disk directory name (Strategy 2). When a skill's directory is a shorter category/alias that differs from its frontmatter name, skill_view(name) failed to find it. Extend the recursive Strategy-2 walk to also match frontmatter `name:`, guarded by a try/except so an unreadable/malformed SKILL.md can't break discovery. Adds a regression test that creates a skill whose directory name differs from its frontmatter name and asserts skill_view resolves it (fails on current main, passes with this change). Salvaged the skill_view fix from NousResearch#39682 onto current main as a standalone, single-concern change with the test the original PR lacked. Co-authored-by: foras910521-lab <foras910521-lab@users.noreply.github.com>
Collaborator
|
Duplicate of #30906 — same |
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
…er-name-lookup fix(skills): resolve skill_view by frontmatter name when dir name differs
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
…ew-frontmatter-name-lookup fix(skills): resolve skill_view by frontmatter name when dir name differs
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ew-frontmatter-name-lookup fix(skills): resolve skill_view by frontmatter name when dir name differs
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…ew-frontmatter-name-lookup fix(skills): resolve skill_view by frontmatter name when dir name differs
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…ew-frontmatter-name-lookup fix(skills): resolve skill_view by frontmatter name when dir name differs
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…ew-frontmatter-name-lookup fix(skills): resolve skill_view by frontmatter name when dir name differs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
skill_viewto resolve a skill by its frontmattername:when the on-disk directory name differs.skills_list()surfaces each skill's frontmattername:, butskill_view()previously only matched on the on-disk directory name (Strategy 2). When a skill's directory is a shorter category/alias that differs from its frontmatter name,skill_view(name)failed to find it. The recursive Strategy-2 walk now also matches frontmattername:, guarded by a try/except so an unreadable/malformedSKILL.mdcan't break discovery.Context
This is a single-concern salvage of one part of #39682, lifted onto current
main. The original PR shipped this change without a test; this PR adds one. The other concerns in #39682 are already resolved upstream (Desktopdist/**and nested-category plugin discovery both landed onmainseparately), and the Langfuse data-URI fix from that PR is sent as its own PR.Test Plan
test_view_skill_by_frontmatter_name_when_dir_differs).main(skill not found) and passes with this change, proving it exercises the new frontmatter-name lookup path.ruff checkclean on touched files.Co-authored-by: foras910521-lab foras910521-lab@users.noreply.github.com