fix: resolve skills by frontmatter name - #28305
Closed
SungKyeol wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
|
This is implemented on current Automated hermes-sweeper review evidence:
Thanks for contributing the fix; the same behavior is already present on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill_view()so it can resolve skills by the canonicalname:inSKILL.mdfrontmatter, not only by directory name.Core bug
skills_listused the frontmatter name, whileskill_viewused the directory name.That meant the same skill system could expose a name that was not actually loadable:
For example, a skill stored under a directory like
brainstorming/but declaring:could appear in skill listings or autocomplete as
superpowers-brainstorming, butskill_view("superpowers-brainstorming")failed because lookup only matched the directory name.Fix
When scanning
SKILL.mdfiles,skill_view()now matches either:name:value from the skill frontmatter.This keeps listing and loading behavior consistent.
Tests
python -m pytest tests/tools/test_skills_tool.py tests/test_plugin_skills.py -q -o 'addopts='