Skip to content

fix(cron): pass shell scripts to bash with forward slashes - #43281

Closed
bigleaguer wants to merge 1 commit into
NousResearch:mainfrom
bigleaguer:fix/43073-cron-sh-windows-paths-pr
Closed

fix(cron): pass shell scripts to bash with forward slashes#43281
bigleaguer wants to merge 1 commit into
NousResearch:mainfrom
bigleaguer:fix/43073-cron-sh-windows-paths-pr

Conversation

@bigleaguer

Copy link
Copy Markdown

Summary

  • Pass .sh and .bash cron script paths to bash with forward slashes.
  • Keep Python script execution unchanged.
  • Add regression coverage for Windows-style script paths.

Fixes #43073

Tests

  • .\.venv\Scripts\python.exe -m pytest tests/cron/test_cron_script.py --timeout-method=thread
  • .\.venv\Scripts\python.exe -m pytest tests/tools/test_windows_native_support.py::TestCronSchedulerBashResolution --timeout-method=thread
  • .\.venv\Scripts\python.exe -m ruff check cron/scheduler.py tests/cron/test_cron_script.py

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cron Cron scheduler and job management duplicate This issue or pull request already exists labels Jun 10, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #43076 — both fix the same cron scheduler bug (#43073): bash .sh/.bash script paths mangled by backslashes on native Windows, fixed by passing forward/POSIX-style paths while leaving Python script execution unchanged. #43076 arrived first. Also part of the long-standing cluster #23404 / #23405 / #23489. Maintainer to pick the canonical fix.

@bigleaguer

Copy link
Copy Markdown
Author

Closing this since #43076 already covers the same fix and was opened first. Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cron Cron scheduler and job management duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: .sh cron scripts fail on Windows - bash receives mangled backslash paths

2 participants