fix(cron): pass shell scripts to bash with POSIX paths - #43076
Closed
BROCCOLO1D wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 10, 2026
Contributor
Author
|
Closing this as stale: there has been no activity or maintainer follow-up for over a week, and I don't want to leave inactive work open. Happy to reopen/rework if this becomes useful. |
1 task
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.sh/.bashcron script execution on Windows by passing Git Bash a forward-slash script path.Why
str(Path(...))produces backslash-separated Windows paths.C:\Users\...\cron-watchdog.share mangled before execution.Changes
cron/scheduler.py: formats bash script argv paths viaPath.as_posix()while leaving Python script execution unchanged.tests/cron/test_cron_script.py: adds a regression check for Windows path conversion.Validation
python -m pytest tests/cron/test_cron_script.py -o 'addopts=' -qpython -m py_compile cron/scheduler.pypython -m ruff check cron/scheduler.py tests/cron/test_cron_script.pyScope
.sh/.bashcron script argv path formatting for bash.